Skip to content

Update typeinfo tracking #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kieronlanning merged 5 commits into from
Jul 27, 2025
Merged

Update typeinfo tracking #76

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1df12f9
fix: fixing nullable ActivityContext parameter usage, #74
kieronlanning Jul 27, 2025
3ff544b
chore(release): 3.2.4-prerelease.0
kieronlanning Jul 27, 2025
026ab2e
chore: restored the old logo - not sure how, why, or when that changed
kieronlanning Jul 27, 2025
8c52f9d
chore(release): 3.2.4-prerelease.1
kieronlanning Jul 27, 2025
473dcb0
chore(release): 3.2.4
kieronlanning Jul 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
The diff you're trying to view is too large. We only load the first 3000 changed files.
13 changes: 13 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,19 @@

All notable changes to this project will be documented in this file. See [commit-and-tag-version](https://github.com/absolute-version/commit-and-tag-version) for commit guidelines.

## [3.2.4](https://github.com/purview-dev/purview-telemetry-sourcegenerator/compare/v3.2.4-prerelease.1...v3.2.4) (2025-07-27)

## [3.2.4-prerelease.1](https://github.com/purview-dev/purview-telemetry-sourcegenerator/compare/v3.2.4-prerelease.0...v3.2.4-prerelease.1) (2025-07-27)

## [3.2.4-prerelease.0](https://github.com/purview-dev/purview-telemetry-sourcegenerator/compare/v3.2.3...v3.2.4-prerelease.0) (2025-07-27)


### Bug Fixes

* accidently left auto-verifg on ([3163d49](https://github.com/purview-dev/purview-telemetry-sourcegenerator/commit/3163d49d13eccad5115616c8c435b1e9d72d8347))
* fixed the Vertify parameters update ([b474466](https://github.com/purview-dev/purview-telemetry-sourcegenerator/commit/b47446636f4fffce4e77657fce0a31eba4968310))
* fixing nullable ActivityContext parameter usage, [#74](https://github.com/purview-dev/purview-telemetry-sourcegenerator/issues/74) ([1df12f9](https://github.com/purview-dev/purview-telemetry-sourcegenerator/commit/1df12f94664b3feb5b3d90e955c96bc0f137171e))

## [3.2.3](https://github.com/purview-dev/purview-telemetry-sourcegenerator/compare/v3.2.1...v3.2.3) (2025-07-08)

## [3.2.2](https://github.com/purview-dev/purview-telemetry-sourcegenerator/compare/v3.2.1...v3.2.2) (2025-07-08)
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ Use the latest version available on [NuGet](https://www.nuget.org/packages/Purvi
Reference in your `Directory.Build.props` or `.csproj` file:

```xml
<PackageReference Include="Purview.Telemetry.SourceGenerator" Version="3.2.3">
<PackageReference Include="Purview.Telemetry.SourceGenerator" Version="3.2.4">
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets>
</PackageReference>
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "purview-telemetry-sourcegenerator",
"version": "3.2.3",
"version": "3.2.4",
"description": "Generates [`ActivitySource`](https://learn.microsoft.com/en-us/dotnet/api/system.diagnostics.activitysource), [`ILogger`](https://learn.microsoft.com/en-us/dotnet/api/microsoft.extensions.logging.ilogger), and [`Metrics`](https://learn.microsoft.com/en-us/dotnet/api/system.diagnostics.metrics) based on interface methods.",
"readme": "README.md",
"main": "index.js",
Expand Down
2 changes: 1 addition & 1 deletion samples/SampleApp/SampleApp.Host/SampleApp.Host.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<NoWarn>$(NoWarn);CS1591</NoWarn>
</PropertyGroup>
<ItemGroup>
<PackageReference Include="Purview.Telemetry.SourceGenerator" Version="3.2.3">
<PackageReference Include="Purview.Telemetry.SourceGenerator" Version="3.2.4">
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets>
</PackageReference>
Expand Down
8 changes: 4 additions & 4 deletions src/Directory.Packages.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,11 @@
<PackageVersion Include="NCrunch.Framework" Version="5.11.0" />
<PackageVersion Include="NSubstitute" Version="5.3.0" />
<PackageVersion Include="NSubstitute.Analyzers.CSharp" Version="1.0.17" />
<PackageVersion Include="xunit.v3" Version="2.0.3" />
<PackageVersion Include="xunit.analyzers" Version="1.22.0" />
<PackageVersion Include="xunit.runner.visualstudio" Version="3.1.1" />
<PackageVersion Include="xunit.v3" Version="3.0.0" />
<PackageVersion Include="xunit.analyzers" Version="1.23.0" />
<PackageVersion Include="xunit.runner.visualstudio" Version="3.1.3" />
<PackageVersion Include="Verify.SourceGenerators" Version="2.5.0" />
<PackageVersion Include="Verify.Xunitv3" Version="30.4.0" />
<PackageVersion Include="Verify.Xunitv3" Version="30.5.0" />
<PackageVersion Include="Verify.DiffPlex" Version="3.1.2" />
</ItemGroup>
</Project>
8 changes: 4 additions & 4 deletions ...ator.IntegrationTests/Activities/TelemetrySourceGeneratorActivityTests.BasicContextGen.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ public async Task Generate_GivenBasicContextGenWithReturningActivity_GeneratesAc
namespace Testing;

[ActivitySource(""testing-activity-source"")]
public interface ITestActivities
public interface ITestActivities
{
[Activity]
System.Diagnostics.Activity? Activity();
Expand Down Expand Up @@ -102,7 +102,7 @@ public async Task Generate_GivenBasicContextGenWithNullableParams_GeneratesActiv
namespace Testing;

[ActivitySource(""testing-activity-source"")]
public interface ITestActivities
public interface ITestActivities
{
[Activity]
System.Diagnostics.Activity? Activity();
Expand Down Expand Up @@ -134,7 +134,7 @@ public async Task Generate_GivenBasicContextGenWithActivity_GeneratesActivity()
namespace Testing;

[ActivitySource(""testing-activity-source"")]
public interface ITestActivities
public interface ITestActivities
{
[Activity]
System.Diagnostics.Activity? Activity();
Expand Down Expand Up @@ -166,7 +166,7 @@ public async Task Generate_GivenBasicContextGenWithActivityAndNoReturn_Generates
namespace Testing;

[ActivitySource(""testing-activity-source"")]
public interface ITestActivities
public interface ITestActivities
{
[Activity]
System.Diagnostics.Activity? Activity();
Expand Down
4 changes: 2 additions & 2 deletions ...ceGenerator.IntegrationTests/Activities/TelemetrySourceGeneratorActivityTests.BasicGen.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ public interface ITestActivities {
await TestHelpers.Verify(
generationResult,
config: s => s.ScrubInlineGuids(),
validateNonEmptyDiagnostics: true
expectsDiagnostics: true
);
}

Expand Down Expand Up @@ -118,7 +118,7 @@ public interface ITestActivities {
await TestHelpers.Verify(
generationResult,
s => s.ScrubInlineGuids(),
validateNonEmptyDiagnostics: true
expectsDiagnostics: true
);
}

Expand Down
100 changes: 100 additions & 0 deletions ...enerator.IntegrationTests/Activities/TelemetrySourceGeneratorActivityTests.ParentTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,100 @@
namespace Purview.Telemetry.SourceGenerator.Activities;

partial class TelemetrySourceGeneratorActivityTests
{
[Fact]
public async Task Generate_GivenActivityContext_GeneratesActivityAndSetsActivityContext()
{
// Arrange
const string basicActivity =
@"
using Purview.Telemetry.Activities;

namespace Testing;

[ActivitySource(""testing-activity-source"")]
public interface ITestActivities {
[Activity]
System.Diagnostics.Activity? Activity(System.Diagnostics.ActivityContext parentContext);
}
";

// Act
var generationResult = await GenerateAsync(basicActivity);

// Assert
await TestHelpers.Verify(generationResult);
}

[Fact]
public async Task Generate_GivenNullableActivityContext_GeneratesActivityAndSetsActivityContextOrDefault()
{
// Arrange
const string basicActivity =
@"
using Purview.Telemetry.Activities;

namespace Testing;

[ActivitySource(""testing-activity-source"")]
public interface ITestActivities {
[Activity]
System.Diagnostics.Activity? Activity(System.Diagnostics.ActivityContext? parentContext);
}
";

// Act
var generationResult = await GenerateAsync(basicActivity);

// Assert
await TestHelpers.Verify(generationResult);
}

[Fact]
public async Task Generate_GivenParentId_GeneratesActivityAndSetsParentId()
{
// Arrange
const string basicActivity =
@"
using Purview.Telemetry.Activities;

namespace Testing;

[ActivitySource(""testing-activity-source"")]
public interface ITestActivities {
[Activity]
System.Diagnostics.Activity? Activity(string parentId);
}
";

// Act
var generationResult = await GenerateAsync(basicActivity);

// Assert
await TestHelpers.Verify(generationResult);
}

[Fact]
public async Task Generate_GivenNullableParentId_GeneratesActivityAndSetsParentId()
{
// Arrange
const string basicActivity =
@"
using Purview.Telemetry.Activities;

namespace Testing;

[ActivitySource(""testing-activity-source"")]
public interface ITestActivities {
[Activity]
System.Diagnostics.Activity? Activity(string? parentId);
}
";

// Act
var generationResult = await GenerateAsync(basicActivity);

// Assert
await TestHelpers.Verify(generationResult);
}
}
4 changes: 2 additions & 2 deletions ...etry.SourceGenerator.IntegrationTests/Activities/TelemetrySourceGeneratorActivityTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ public interface ITestActivities<{genericTypeDef}>
await TestHelpers.Verify(
generationResult,
c => c.ScrubInlineGuids(),
validateNonEmptyDiagnostics: true,
expectsDiagnostics: true,
parameters: genericTypeCount
);
}
Expand Down Expand Up @@ -115,7 +115,7 @@ public interface ITestActivities
await TestHelpers.Verify(
generationResult,
c => c.ScrubInlineGuids(),
validateNonEmptyDiagnostics: true,
expectsDiagnostics: true,
parameters: genericTypeCount
);
}
Expand Down
2 changes: 1 addition & 1 deletion ...tor.IntegrationTests/Logging/TelemetrySourceGeneratorLoggingGen2Tests.ExpandEnumerable.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ public interface ITestLogger
await TestHelpers.Verify(
generationResult,
c => c.ScrubInlineGuids(),
validateNonEmptyDiagnostics: true,
expectsDiagnostics: true,
parameters: maxCount
);
}
Expand Down
2 changes: 1 addition & 1 deletion ...erator.IntegrationTests/Logging/TelemetrySourceGeneratorLoggingGen2Tests.LogProperties.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ public class WeatherForecast
);

// Assert
await TestHelpers.Verify(generationResult, validateNonEmptyDiagnostics: true);
await TestHelpers.Verify(generationResult, expectsDiagnostics: true);
}

[Fact]
Expand Down
4 changes: 2 additions & 2 deletions ...eGenerator.IntegrationTests/Logging/TelemetrySourceGeneratorLoggingGen2Tests.ScopedGen.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ public interface ITestLogger
);

// Assert
await TestHelpers.Verify(generationResult, validateNonEmptyDiagnostics: true);
await TestHelpers.Verify(generationResult, expectsDiagnostics: true);
}

[Fact]
Expand Down Expand Up @@ -176,6 +176,6 @@ public interface ITestLogger
);

// Assert
await TestHelpers.Verify(generationResult, validateNonEmptyDiagnostics: true);
await TestHelpers.Verify(generationResult, expectsDiagnostics: true);
}
}
4 changes: 2 additions & 2 deletions ...etry.SourceGenerator.IntegrationTests/Logging/TelemetrySourceGeneratorLoggingGen2Tests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ public interface ITestLogger<{genericTypeDef}> {{
await TestHelpers.Verify(
generationResult,
c => c.ScrubInlineGuids(),
validateNonEmptyDiagnostics: true,
expectsDiagnostics: true,
parameters: genericTypeCount
);
}
Expand Down Expand Up @@ -113,7 +113,7 @@ public interface ITestLogger<{genericTypeDef}> {{
await TestHelpers.Verify(
generationResult,
c => c.ScrubInlineGuids(),
validateNonEmptyDiagnostics: true,
expectsDiagnostics: true,
parameters: genericTypeCount
);
}
Expand Down
6 changes: 3 additions & 3 deletions ...SourceGenerator.IntegrationTests/Logging/TelemetrySourceGeneratorLoggingTests.BasicGen.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ public interface ITestLogger {
await TestHelpers.Verify(
generationResult,
c => c.ScrubInlineGuids(),
validateNonEmptyDiagnostics: true
expectsDiagnostics: true
);
}

Expand All @@ -128,7 +128,7 @@ public interface ITestLogger {
await TestHelpers.Verify(
generationResult,
c => c.ScrubInlineGuids(),
validateNonEmptyDiagnostics: true,
expectsDiagnostics: true,
validationCompilation: false
);
}
Expand Down Expand Up @@ -156,7 +156,7 @@ public interface ITestLogger {
await TestHelpers.Verify(
generationResult,
c => c.ScrubInlineGuids(),
validateNonEmptyDiagnostics: true,
expectsDiagnostics: true,
validationCompilation: false
);
}
Expand Down
2 changes: 1 addition & 1 deletion ...ceGenerator.IntegrationTests/Logging/TelemetrySourceGeneratorLoggingTests.NoILoggerRef.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ public interface ITestActivities {
// Assert
await TestHelpers.Verify(
generationResult,
validateNonEmptyDiagnostics: false,
expectsDiagnostics: false,
whenValidatingDiagnosticsIgnoreNonErrors: true
);
}
Expand Down
4 changes: 2 additions & 2 deletions ...elemetry.SourceGenerator.IntegrationTests/Logging/TelemetrySourceGeneratorLoggingTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ public interface ITestLogger<{genericTypeDef}> {{
await TestHelpers.Verify(
generationResult,
c => c.ScrubInlineGuids(),
validateNonEmptyDiagnostics: true,
expectsDiagnostics: true,
parameters: genericTypeCount
);
}
Expand Down Expand Up @@ -103,7 +103,7 @@ public interface ITestLogger<{genericTypeDef}> {{
await TestHelpers.Verify(
generationResult,
c => c.ScrubInlineGuids(),
validateNonEmptyDiagnostics: true,
expectsDiagnostics: true,
parameters: genericTypeCount
);
}
Expand Down
4 changes: 2 additions & 2 deletions ...SourceGenerator.IntegrationTests/Metrics/TelemetrySourceGeneratorMetricsTests.Counters.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ public interface ITestMetrics
await TestHelpers.Verify(
generationResult,
config: c => c.ScrubInlineGuids(),
validateNonEmptyDiagnostics: true,
expectsDiagnostics: true,
validationCompilation: false
);
}
Expand Down Expand Up @@ -107,7 +107,7 @@ public interface ITestMetrics
await TestHelpers.Verify(
generationResult,
c => c.ScrubInlineGuids(),
validateNonEmptyDiagnostics: true,
expectsDiagnostics: true,
validationCompilation: false
);
}
Expand Down
4 changes: 2 additions & 2 deletions ...elemetry.SourceGenerator.IntegrationTests/Metrics/TelemetrySourceGeneratorMetricsTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ public interface ITestMetrics<{genericTypeDef}> {{
await TestHelpers.Verify(
generationResult,
c => c.ScrubInlineGuids(),
validateNonEmptyDiagnostics: true,
expectsDiagnostics: true,
parameters: genericTypeCount
);
}
Expand Down Expand Up @@ -128,7 +128,7 @@ public interface ITestMetrics<{genericTypeDef}> {{
await TestHelpers.Verify(
generationResult,
c => c.ScrubInlineGuids(),
validateNonEmptyDiagnostics: true,
expectsDiagnostics: true,
parameters: genericTypeCount
);
}
Expand Down
Loading
Loading