fix(dsa): reject invalid domain parameters to prevent universal signature forgery#646
Merged
kjur merged 2 commits intokjur:masterfrom Feb 20, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a high-impact DSA verification issue caused by missing domain-parameter validation.
Without validation, attacker-controlled DSA parameters (e.g.
g=1,y=1) can make verification accept a forged signature for arbitrary message hashes.Root Cause
KJUR.crypto.DSAaccepted public parameters without checking DSA domain/public key constraints.As a result, verification could be performed on invalid groups/keys.
Changes
src/dsa-2.0.jssetPublic):1 < q < p1 < g < pg^q mod p == 11 < y < pError: invalid DSA public keytest/qunit-do-dsa.htmlsetPublicHexrejectsg=1test/qunit-do-x509.htmlg=1is rejected byX509.verifySignatureSecurity Impact
Prevents universal DSA signature forgery under malicious parameters and blocks forged-certificate acceptance in DSA verification flows that consume untrusted keys/certs.
Validation
g=1): forged signature/cert accepted.invalid DSA public key), forged verification fails.npm testinnpm/passes.