fix(crypto): correct compareTo checks in BigInteger RNG helpers#647
Merged
kjur merged 1 commit intokjur:masterfrom Feb 20, 2026
Merged
fix(crypto): correct compareTo checks in BigInteger RNG helpers#647kjur merged 1 commit intokjur:masterfrom
kjur merged 1 commit intokjur:masterfrom
Conversation
bc11065 to
de2b309
Compare
b022050 to
d89f0ec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes incorrect
compareTohandling in BigInteger rejection sampling utilities used by DSA nonce generation.Root Cause
BigInteger.compareTomay return any positive/negative integer, but code assumed sentinel values (-1/1), causing:getRandomBigIntegerZeroToMaxgetRandomBigIntegerMinToMaxFix
src/crypto-1.1.jsbiMax.compareTo(biRand) != -1->biMax.compareTo(biRand) >= 0flagCompare == 1->flagCompare > 0Tests
Added regressions in
test/qunit-do-crypto.html:getRandomBigIntegerZeroToMaxcompareToresult ingetRandomBigIntegerMinToMaxValidation
overflow = 0.npm testmay depend on local network/installed dependencies.