fix(jsbn2): reject non-positive values in primality checks#651
Merged
kjur merged 1 commit intokjur:masterfrom Feb 20, 2026
Merged
fix(jsbn2): reject non-positive values in primality checks#651kjur merged 1 commit intokjur:masterfrom
kjur merged 1 commit intokjur:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes BigInteger primality checks for non-positive inputs.
isProbablePrimepreviously operated onabs(this)and could returntruefor negative values (e.g.
-7,-97). Since primes are defined only forpositive integers greater than 1, this is incorrect behavior.
Changes
ext/jsbn2.jsbnIsProbablePrime(t): now returnsfalsewhenthis.signum() <= 0bnpMillerRabin(t): adds the same defensive guard for non-positive inputtest/qunit-do-crypto.htmlfalseWhy
This ensures primality checks are mathematically correct and avoids accepting
invalid negative parameters in callers that rely on
isProbablePrime.Validation
-2, -7, -13, -97->false7->true,4->falsenpm testpasses