Skip to content

Conversation

kkebo
Copy link
Owner

@kkebo kkebo commented Oct 3, 2024

No description provided.

@kkebo kkebo self-assigned this Oct 3, 2024
@kkebo kkebo force-pushed the enable-symlink-tests branch from cb0d434 to bdeb322 Compare October 3, 2024 19:10
@kkebo kkebo changed the title test(FileIteratorTests): enable tests related to symlink test(wasi): enable tests related to symlink Oct 3, 2024
@kkebo kkebo force-pushed the enable-symlink-tests branch 4 times, most recently from ea10895 to dee2289 Compare October 5, 2024 23:11
@kkebo
Copy link
Owner Author

kkebo commented Oct 8, 2024

Features we need:

  1. symlink() can create absolute symlinks
  2. readlink() can read absolute symlinks
  3. readdir() can return absolute symlinks
  4. call stack size can be increased

Runtimes comparison:

wasmtime Wasmer WasmKit WasmEdge
1. symlink() ❌ (relative only) ❌ (relative only) ❌?
2. readlink() ❌ (relative only) ❌ (relative only)
3. readdir() ❌ (relative only)
4. call stack size ❌?

@kkebo kkebo force-pushed the enable-symlink-tests branch 2 times, most recently from 9487f1b to cb531a7 Compare October 10, 2024 12:31
@kkebo
Copy link
Owner Author

kkebo commented Oct 19, 2024

I'm going to create another PR #116 to enable relative symlink tests while leaving absolute symlink tests disabled. This PR will focus on absolute symlink tests.

@kkebo kkebo changed the title test(wasi): enable tests related to symlink test(wasi): enable absolute symlink tests Oct 19, 2024
@kkebo kkebo force-pushed the enable-symlink-tests branch from cb531a7 to 1c57532 Compare October 19, 2024 19:02
@kkebo kkebo marked this pull request as draft October 19, 2024 19:02
@kkebo kkebo force-pushed the enable-symlink-tests branch from 1c57532 to 5447da0 Compare October 18, 2025 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant