Enhance DNS check with better error handling#274
Open
upbeat-backbone-bose wants to merge 1 commit intokkkgo:mainfrom
Open
Enhance DNS check with better error handling#274upbeat-backbone-bose wants to merge 1 commit intokkkgo:mainfrom
upbeat-backbone-bose wants to merge 1 commit intokkkgo:mainfrom
Conversation
Refactor DNS check logic to improve error handling and logging. [For dns114] If dig returns empty or timeout → considered as failure If returns 127.0.0.* (any loopback) → record the original value but treat t3 as passed (y) Other normal IPs → passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor DNS check logic to improve error handling and logging.
[For dns114]
If dig returns empty or timeout → considered as failure
If returns 127.0.0.* (any loopback) → record the original value but treat t3 as passed (y)
Other normal IPs → passed