Conversation
|
I'll give this a spin in our internal CI sometime this week. @zmstone |
test/avro_tests.erl
Outdated
| assert_struct_equal(avro_json, Expect, Got) -> | ||
| assert_strcut_equal_no_fields_order(Expect, Got). | ||
|
|
||
| assert_strcut_equal_no_fields_order(Value, Value) -> |
|
Locally we add |
| json -> | ||
| iolist_to_binary(json:encode(Value, fun encoder/2)); | ||
| Module -> | ||
| apply(Module, encode, [Value, Options]) |
There was a problem hiding this comment.
nit: why the apply instead of simply Module:encode(Value, Options)? (likewise below for decode)
There was a problem hiding this comment.
it's due to elvis style check.
# src/avro_json_compat.erl [FAIL]
- invalid_dynamic_call (https://github.com/inaka/elvis_core/tree/main/doc_rules/elvis_style/invalid_dynamic_call.md)
- Remove the dynamic function call on line 95. Only modules that define callbacks should make dynamic calls.
An |
|
Sorry, GH tricked me there. |
|
I'm getting dialyzer errors in application code using |
|
Specifically, |
|
thanks for the review @mikpe , pushed a few fixes. |
|
Tagged 2.11.0 and published to hex. Thanks @zmstone |
2 participants
fixes: #128