Skip to content

Conversation

@antonyantony
Copy link
Collaborator

No description provided.

eesp-ikev2.org Outdated
Sub SA ID. If the receiver is pre-populating a Sub SA, it may have
to install it with a source port set to zero and, upon arrival of a
packet, update the source port using a mapping change for for this,
uni-directional Sub SA
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, how does this relate to SK_sub (as the title suggests)? And aren't all IPsec SAs unidirectional by definition? Why point it out here specifically?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh that is not part of this. That was part of UDP encap clarifications.I will move it there. Thanks.

I hope to clarify SK_sub derived from KEYMAT is directional
@antonyantony antonyantony force-pushed the antony/edit-3-sub-sa-kdf-fixes branch from ef5d9cb to fb9ccff Compare February 12, 2025 16:00
keys, SK_sub, is determined by the key size of the negotiated SSKDF.
The root key(s) for the initiator-to-responder direction are derivedi
before those for the responder-to-initiator direction.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's not correct. We only get keys used for SSKDF here, not the individual keys for encryption/integrity algorithms. So this does not depend on the algorithms at all (except for the SSKDF key size). That difference is only relevant when applying SSKDF later to derive KEYMAT_sub using the key we got here.

Comment on lines +383 to +384
Keys for Sub SAs may be derived immediately after IKE negoation of
the Child SA or on demand when the first packet is processed. Memory
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe use during IKE negotiation because "after" is a bit confusing.

Comment on lines +257 to +258
negotiation of the EESP Child SA. This Sub SA ID is used to derive
a unique key, yielding the following benefits:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, not sure if these benefits result from that unique key. Some are just benefits of having Sub SAs.

Comment on lines +261 to +262
SAs of [[RFC9611]], which are alwaya a pair of unidirectional SAs,
Sub SAs MAY be defined strictly in one direction when reverse traffic is
Copy link
Collaborator

@tobiasbrunner tobiasbrunner Feb 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, this seems a bit confusing as well. How can they be "defined" in strictly one direction? Do you mean that there could be more Sub SAs in one direction than the other? (One peer just wanting to accept one sub SA with Session ID 0 and the other allowing more.)

Copy link
Collaborator

@smyslov smyslov Feb 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps there is some misunderstanding of what was agreed upon at the last conference call. My understanding is that each side can create as many Sub SAs (acting as sender) as the other side indicated it is ready to accept (acting as a receiver). There is no requirement that these numbers are equal. During Child SA establishment each side would send a notify, indicating how many Sud SAs it can tolerate as a receiver. There is no negotiation, the values can differ - it is OK that for example when the initiator can handle up to 5 incoming Sub SAs and the responder can handle 20 of them. This is very similar (but simplified) to the concept of STREAMs in QUIC (RFC 9000). In QUIC new streams are created by senders at any time, but the total number of streams they can create is limited by the MAX_STREAMS message, that was sent earlier by the peer. In case of EESP this concept is simplified (no individual deletion of Sub SAs, no dynamic update of the maximum number of Sub SAs, etc.), but the idea is the same.
Are we here on the same page or not?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes. Valery. I think this what we are trying write down.
Though I have one further question. In the call, did we clarify the number proposed is in one direction or combined ? I think for one direction. I didn't add that to the notifier.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Each side informs the other side about what is the maximum number of incoming Sub SAs it is ready to handle. This doesn't include Sub SAs this party would create as a sender (outgoing). Thus, each proposal (in fact, this is not "proposal", this is an "announcement", since there is no negotiation, just an information) counts only incomimg Sub SAs, not both directions.

@antonyantony
Copy link
Collaborator Author

this is moved to the other draft. May be I will bring it there.

@antonyantony antonyantony deleted the antony/edit-3-sub-sa-kdf-fixes branch February 27, 2025 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants