Use category collection to load product categories in single query #53
Open
andrewkett wants to merge 1 commit intoklaviyo:masterfrom
Open
Use category collection to load product categories in single query #53andrewkett wants to merge 1 commit intoklaviyo:masterfrom
andrewkett wants to merge 1 commit intoklaviyo:masterfrom
Conversation
…ther than one per category
Contributor
|
Any update on this Klaviyo team? Query in a loop can be a huge performance anti-pattern in Magento which could make customers' stores really slow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently on product pages the extension carries out a category load for every category that the product is in, this results in a database read each time. On sites that have a lot of categorisation this means a large number of queries are carried out for something that could be achieved in a single query.
This pull request replaces the category load with a category collection loading categories by id, this will always use a single query to load the product categories.