refactor(rakmaty-survey): never use await in a loop, add editorconfig#1
Open
marekvospel wants to merge 3 commits intoklubFITpp:mainfrom
Open
refactor(rakmaty-survey): never use await in a loop, add editorconfig#1marekvospel wants to merge 3 commits intoklubFITpp:mainfrom
marekvospel wants to merge 3 commits intoklubFITpp:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using await inside a loop, each iteration has to wait till the previous one is finished - each request is blocking the whole computation. I refactored the code to be less nested and to use the Promise utilities and Array prototype functions
Promise.all([promise1, promise2])- starts all promises at the same time, waits till all are done or till one rejects (error is thrown)Promise.allSettled[promise1, promise2])- starts all promises at the same time, waits till all are done, doesnt fail if promise rejects[1, 2, 3, 4].filter(num => num > 2)filters elements based on supplied predicate (returns new array with elements that satisfy said predicate)[true, false, undefined, null, true].filter(Boolean)filters based on whether value is truthy / falsy - boolean constructor is used as a predicate[[1, 2], [3, 4]].flat()flattens nested arrays into a single array (isnt recursive) - returns[1, 2, 3, 4]