fix(deploy): clusterrole manager role #152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Hello @codablock Could you please, release a Helm chart version v0.9.4 if possible with this fix ? Thank you very much in advance. |
Contributor
|
@smehboub I modified this PR to use the kubebuilder functionality to auto-generate the RBAC rules. After CI verfifies that its good, I will merge and create a release. |
Contributor
|
Some more context: With kubebuilder, you change RBAC via these magic comments and then invoke some internal commands to make kubebuilder regenerate manifests. The shortcut is to use "make helm-manifests" |
codablock
force-pushed
the
fix/deploy/manager-role
branch
from
be2ea23 to
09d6e21
Compare
Contributor
Author
|
Hi @codablock Okay great. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #151