Skip to content

fix(deploy): clusterrole manager role #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
codablock merged 2 commits into from
Feb 14, 2025
Merged

fix(deploy): clusterrole manager role #152

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7dc6893
fix(deploy): clusterrole manager role
smehboub Feb 9, 2025
09d6e21
fix: Fix RBAC via kubebuilder comments
codablock Feb 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions config/rbac/role.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ rules:
- ""
resources:
- configmaps
- namespaces
verbs:
- get
- list
Expand Down
2 changes: 1 addition & 1 deletion controllers/comments/githubcomment_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ type GithubCommentReconciler struct {
//+kubebuilder:rbac:groups=templates.kluctl.io,resources=githubcomments,verbs=get;list;watch;create;update;patch;delete
//+kubebuilder:rbac:groups=templates.kluctl.io,resources=githubcomments/status,verbs=get;update;patch
//+kubebuilder:rbac:groups=templates.kluctl.io,resources=githubcomments/finalizers,verbs=update
//+kubebuilder:rbac:groups="",resources=configmaps,verbs=get;list;watch
//+kubebuilder:rbac:groups="",resources=configmaps;namespaces,verbs=get;list;watch

func (r *GithubCommentReconciler) Reconcile(ctx context.Context, req ctrl.Request) (result ctrl.Result, err error) {
logger := log.FromContext(ctx)
Expand Down
2 changes: 1 addition & 1 deletion controllers/comments/gitlabcomment_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ type GitlabCommentReconciler struct {
//+kubebuilder:rbac:groups=templates.kluctl.io,resources=gitlabcomments,verbs=get;list;watch;create;update;patch;delete
//+kubebuilder:rbac:groups=templates.kluctl.io,resources=gitlabcomments/status,verbs=get;update;patch
//+kubebuilder:rbac:groups=templates.kluctl.io,resources=gitlabcomments/finalizers,verbs=update
//+kubebuilder:rbac:groups="",resources=configmaps,verbs=get;list;watch
//+kubebuilder:rbac:groups="",resources=configmaps;namespaces,verbs=get;list;watch

func (r *GitlabCommentReconciler) Reconcile(ctx context.Context, req ctrl.Request) (result ctrl.Result, err error) {
logger := log.FromContext(ctx)
Expand Down
1 change: 1 addition & 0 deletions deploy/charts/template-controller/templates/rbac/ClusterRole-manager-role.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ rules:
- ""
resources:
- configmaps
- namespaces
verbs:
- get
- list
Expand Down
1 change: 1 addition & 0 deletions deploy/manifests/template-controller.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1714,6 +1714,7 @@ rules:
- ""
resources:
- configmaps
- namespaces
verbs:
- get
- list
Expand Down
Loading