fix(#109): Sync daemon_state.inserted_cents when plugin deducts/refunds#145
Merged
fix(#109): Sync daemon_state.inserted_cents when plugin deducts/refunds#145
Conversation
- Add plugins_adjust_inserted_cents(delta) for plugins to sync coin state - classic_phone: call it when deducting for paid call and when refunding on call failure - daemon: implement with mutex; prevents API/persistence showing wrong balance - Simulator and unit_tests: add stub implementations Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #109
Problem:
daemon_state->inserted_centsandclassic_phone_data.inserted_centscould desync when the plugin deducted for paid calls (only plugin updated) or refunded on call failure (only plugin updated).Fix:
plugins_adjust_inserted_cents(int delta)so plugins can sync daemon_state when they deduct or refund coinsResult: API, persistence, and display all agree on coin balance.
Made with Cursor