fix(#119): Make /api/check-update non-blocking#148
Merged
Conversation
- updater_check_async(): starts background thread for curl; returns immediately - updater_is_checking(): returns 1 when check in progress - API handler uses check_async instead of blocking updater_check - Response includes "checking":true when curl running in background - Prevents HTTP handler from blocking up to 10s on slow/unreachable network Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #119
Problem:
updater_checkusedpopen("curl -s -m 10 ...")which blocks for up to 10 seconds. When called from/api/check-update, the web server thread blocks.Fix:
updater_check_async(): starts a background thread for curl; returns immediatelyupdater_is_checking(): returns 1 when a check is in progressupdater_check_async()instead of blockingupdater_check()"checking":truewhen curl is running in backgroundResult: Dashboard "Check Updates" no longer hangs for 10 seconds on poor network.
Made with Cursor