Merged
Conversation
- updater_apply_async(): runs git pull, make, install in background thread - updater_is_applying(): returns 1 when apply in progress - API handler uses apply_async, returns 202 Accepted immediately - Prevents web server from blocking for minutes during update - apply_status protected by mutex for thread safety Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #118
Problem:
updater_applyblocks the web server thread for minutes (git pull, make, sudo make install).Fix:
updater_apply_async(): runs the full apply in a background thread; returns immediatelyupdater_is_applying(): returns 1 when apply is in progressupdater_apply_async(), returns 202 Accepted with status messageapply_statusprotected by mutex for thread safetyResult: Dashboard update button no longer blocks the web server for minutes.
Made with Cursor