Open
Conversation
kmilogp
reviewed
Oct 19, 2024
Owner
There was a problem hiding this comment.
I think we could remove the base editors and use only the diff editor for this feature. A few reasons:
- The input and output editor occupy most of the screen, which makes the scroll unavoidable when the diff appears
- A second iteration for checking a diff implies having to go to the top of the screen to generate a diff and then go bottom again to see the result
- The diff viewer per se has all the desired features, so we could just use it and even have real time feedback for the user
I would suggest
- Removing the input and output editor
- Adding the editor toolbar for copying the content to the clipboard
- Removing the diff button, it's no necessary for the feature, since probably we won't need error handling
Author
There was a problem hiding this comment.
Thanks for the feedback. Will be adding it. In the end the diff editor was more powerfull than I expected. All your feedback was in a way the correct usage of the editor.
kmilogp
requested changes
Oct 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.