Channels and sources#160
Merged
knative-prow[bot] merged 14 commits intoknative-extensions:mainfrom Feb 20, 2025
Merged
Conversation
knative-prow
bot
added
the
do-not-merge/work-in-progress
knative-prow
bot
added
approved
knative-prow
bot
removed
the
do-not-merge/work-in-progress
knative-prow-robot
added
the
needs-rebase
Signed-off-by: Ali Ok <aliok@redhat.com>
Signed-off-by: Ali Ok <aliok@redhat.com>
Signed-off-by: Ali Ok <aliok@redhat.com>
aliok
force-pushed
the
2024-01-15-channels
branch
from
8a372dd to
eb4b26b
Compare
knative-prow-robot
removed
the
needs-rebase
Signed-off-by: Ali Ok <aliok@redhat.com>
Signed-off-by: Ali Ok <aliok@redhat.com>
Signed-off-by: Ali Ok <aliok@redhat.com>
Signed-off-by: Ali Ok <aliok@redhat.com>
Signed-off-by: Ali Ok <aliok@redhat.com>
aliok
force-pushed
the
2024-01-15-channels
branch
from
f20cc90 to
d129b82
Compare
Signed-off-by: Ali Ok <aliok@redhat.com>
pierDipi
reviewed
Feb 18, 2025
Comment on lines
149
to
152
| logger.Errorw("Error processing subscription", "error", err) | ||
| // do not stop the Backstage plugin from rendering the rest of the data, e.g. because | ||
| // there are no permissions to get a single subscriber resource | ||
| } |
Member
There was a problem hiding this comment.
Shouldn't this skip be associated with the specific error apierrors.IsUnauthorized(err) and fail for others ?
pierDipi
approved these changes
Feb 18, 2025
knative-prow
bot
removed
approved
…ions Signed-off-by: Ali Ok <aliok@redhat.com>
aliok
force-pushed
the
2024-01-15-channels
branch
from
99b3b76 to
8afb5a8
Compare
…ions Signed-off-by: Ali Ok <aliok@redhat.com>
Member
|
/lgtm |
pierDipi
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: aliok, matzew, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some screenshots...
Table:
API server source:
Channel:
