Skip to content

Conversation

@simkam
Copy link
Contributor

@simkam simkam commented Oct 2, 2025

Changes

  • allow testing against the real AWS services instead of LocalStack emulated services

/kind enhancement

@knative-prow
Copy link

knative-prow bot commented Oct 2, 2025

@simkam: The label(s) kind/enhancement cannot be applied, because the repository doesn't have them.

Details

In response to this:

Changes

  • allow testing against the real AWS services instead of LocalStack emulated services

/kind enhancement

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow
Copy link

knative-prow bot commented Oct 2, 2025

Hi @simkam. Thanks for your PR.

I'm waiting for a knative-extensions member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot added the size/XXL label Oct 2, 2025
@simkam simkam marked this pull request as draft October 13, 2025 14:26
@simkam simkam marked this pull request as ready for review October 13, 2025 14:26
@knative-prow knative-prow bot requested review from dsimansk and skonto October 13, 2025 14:26
@simkam
Copy link
Contributor Author

simkam commented Oct 13, 2025

/ok-to-test

Copy link
Contributor

@christophd christophd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dprotaso
Copy link

/assign @matzew @creydr

@knative-prow
Copy link

knative-prow bot commented Nov 17, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christophd, creydr, simkam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit d2acca9 into knative-extensions:main Nov 17, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants