-
Notifications
You must be signed in to change notification settings - Fork 15
Configure multi-architecture support for JIB in eventing-integrations #110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configure multi-architecture support for JIB in eventing-integrations #110
Conversation
|
Welcome @intojhanurag! It looks like this is your first PR to knative-extensions/eventing-integrations 🎉 |
|
Hi @intojhanurag. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Hey @Cali0707 , Can I get a review on this one ? If you have a moment. |
creydr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for you work on this @intojhanurag. I left a comment
|
Hey @creydr , Now is it good to go ? |
|
/ok-to-test |
creydr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @intojhanurag for working on this
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: creydr, intojhanurag The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
fix: #8721
Set up multi-architecture JIB configuration in eventing-integrations POM.
Added amd64, arm64, s390x, and ppc64le platforms to allow building container images for multiple CPU architectures.
This matches the approach used in eventing-kafka-broker and ensures proper image support for KinD e2e tests.