Skip to content

jsonata: allow transforming or discarding responses from K_SINK endpoint#64

Merged
knative-prow[bot] merged 1 commit intoknative-extensions:mainfrom
pierDipi:jsonata-response-transform
Feb 11, 2025
Merged

jsonata: allow transforming or discarding responses from K_SINK endpoint#64
knative-prow[bot] merged 1 commit intoknative-extensions:mainfrom
pierDipi:jsonata-response-transform

Conversation

@pierDipi
Copy link
Member

Sometimes, sink endpoints return invalid JSON values or non CloudEvents, this allows transforming the response the "same" way we transform the request with a potentially different transformation.

Changes

  • allow transforming or discarding responses from K_SINK endpoint

/kind

Fixes #

Release Note

jsonata: allow transforming or discarding responses from K_SINK endpoint

Docs


@knative-prow
Copy link

knative-prow bot commented Feb 10, 2025

@pierDipi: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

Details

In response to this:

Sometimes, sink endpoints return invalid JSON values or non CloudEvents, this allows transforming the response the "same" way we transform the request with a potentially different transformation.

Changes

  • allow transforming or discarding responses from K_SINK endpoint

/kind

Fixes #

Release Note

jsonata: allow transforming or discarding responses from K_SINK endpoint

Docs


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sometimes, sink endpoints return invalid JSON values or non
CloudEvents, this allows transforming the response the "same" way
we transform the request with a potentially different transformation.

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@pierDipi pierDipi force-pushed the jsonata-response-transform branch from cb81225 to 2234492 Compare February 11, 2025 10:01
Copy link
Contributor

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow
Copy link

knative-prow bot commented Feb 11, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 74d1a38 into knative-extensions:main Feb 11, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants