Skip to content

Jsonata: Support creating TLS server#73

Merged
knative-prow[bot] merged 2 commits intoknative-extensions:mainfrom
pierDipi:jsonata-tls-server
Mar 5, 2025
Merged

Jsonata: Support creating TLS server#73
knative-prow[bot] merged 2 commits intoknative-extensions:mainfrom
pierDipi:jsonata-tls-server

Conversation

@pierDipi
Copy link
Member

@pierDipi pierDipi commented Mar 4, 2025

This adds support for creating TLS Server for the JSONata transformation.

Changes

  • Jsonata: Support creating TLS server

/kind

Fixes #

Release Note

Docs

@knative-prow
Copy link

knative-prow bot commented Mar 4, 2025

@pierDipi: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

Details

In response to this:

This adds support for creating TLS Server for the JSONata transformation.

Changes

  • Jsonata: Support creating TLS server

/kind

Fixes #

Release Note

Docs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot requested review from lionelvillard and matzew March 4, 2025 15:23
@pierDipi
Jsonata: Support creating TLS server
076eb25 
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@pierDipi pierDipi force-pushed the jsonata-tls-server branch from a6f31fd to 076eb25 Compare March 4, 2025 15:25
@pierDipi pierDipi mentioned this pull request Mar 4, 2025
Merged
5 tasks
matzew
matzew reviewed Mar 5, 2025
View reviewed changes
transform-jsonata/ssl/server.crt
@@ -0,0 +1,21 @@
-----BEGIN CERTIFICATE-----
Copy link
Contributor

@matzew matzew Mar 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wont these be injected

Copy link
Member Author

@pierDipi pierDipi Mar 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is just for testing / local dev

@pierDipi
Docker exclude dev ssl certs
3464bcd 
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
matzew
matzew approved these changes Mar 5, 2025
View reviewed changes
Copy link
Contributor

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm label Mar 5, 2025
@knative-prow
Copy link

knative-prow bot commented Mar 5, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 6934237 into knative-extensions:main Mar 5, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matzew matzew matzew approved these changes

@lionelvillard lionelvillard Awaiting requested review from lionelvillard

Assignees

@matzew matzew

Labels

approved lgtm size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pierDipi @matzew