Skip to content

fix(#7): Update to Java 21#74

Merged
knative-prow[bot] merged 2 commits intoknative-extensions:mainfrom
christophd:issue/7/java-21
Mar 18, 2025
Merged

fix(#7): Update to Java 21#74
knative-prow[bot] merged 2 commits intoknative-extensions:mainfrom
christophd:issue/7/java-21

Conversation

@christophd
Copy link
Contributor

@christophd christophd commented Mar 10, 2025

Changes

Java 21

  • Update compiler version to Java 21
  • Update Docker image runtime version to Java 21

Self contained Dockerfiles

  • Introduce multi-stage Docker build
  • 1st stage builds the executable Java archive artifact
  • 2nd stage represents the runtime image copying the produced executable artifact

/kind

Fixes #7
Fixes #22

Release Note

Update to Java 21

Docs


@knative-prow
Copy link

knative-prow bot commented Mar 10, 2025

@christophd: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

Details

In response to this:

Changes

  • Update compiler version to Java 21
  • Update Docker image runtime version to Java 21

/kind

Fixes #7

Release Note

Update to Java 21

Docs


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot requested review from Leo6Leo and aliok March 10, 2025 12:23
@knative-prow knative-prow bot added the size/L label Mar 10, 2025
- Introduce multi-stage Docker build
- 1st stage builds the executable Java archive artifact
- 2nd stage represents the runtime image copying the produced executable artifact
@knative-prow knative-prow bot added size/XXL and removed size/L labels Mar 11, 2025
with:
java-version: '17'
java-version: '21'
distribution: 'temurin'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

possible to use registry.access.redhat.com/ubi9/openjdk-21-runtime (or ubi8)?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be done differently

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see your point to use the very same distribution in all places. But I do not think that using the ubi is possible here. This Java distribution in GitHub actions is for running the Maven build to compile and run the tests, only.

Copy link
Contributor

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow
Copy link

knative-prow bot commented Mar 18, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christophd, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 409bd0a into knative-extensions:main Mar 18, 2025
4 checks passed
matzew pushed a commit to matzew/eventing-integrations that referenced this pull request Mar 18, 2025
* fix(knative-extensions#7): Update to Java 21

* fix(knative-extensions#22): Self contained Dockerfiles

- Introduce multi-stage Docker build
- 1st stage builds the executable Java archive artifact
- 2nd stage represents the runtime image copying the produced executable artifact
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Self-contained Dockerfiles use jdk 21

2 participants