Skip to content

Conversation

@Sapthagiri777
Copy link

Fixes #465

Proposed Changes

  • Add TRIGGER_SINK_FAILURES counter metric to Metrics.java
  • Increment the counter in WebClientCloudEventSender when all retries are exhausted or on non-retryable failures
  • Preserve existing retry behaviour while exposing total sink failures per trigger

Release Note

Docs

No user-facing docs change included. This metric follows the existing eventing metrics conventions.

@knative-prow
Copy link

knative-prow bot commented Dec 24, 2025

Welcome @Sapthagiri777! It looks like this is your first PR to knative-extensions/eventing-kafka-broker 🎉

@knative-prow knative-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 24, 2025
@knative-prow
Copy link

knative-prow bot commented Dec 24, 2025

Hi @Sapthagiri777. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 15, 2026
@knative-prow
Copy link

knative-prow bot commented Jan 15, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Sapthagiri777
Once this PR has been reviewed and has the lgtm label, please assign gauron99 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Sapthagiri777
Copy link
Author

Hey @Leo6Leo @pierDipi . This is my first PR here - pretty excited about it!
Just added the sink failures metric from #465. Would really appreciate it if someone could run /ok-to-test when you get a chance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/data-plane needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expose Trigger's sink failures count metric

1 participant