Skip to content

Conversation

@jijo-OO7
Copy link
Contributor

@jijo-OO7 jijo-OO7 commented Jan 9, 2026

TriggerV2: Cross-namespace BrokerRef Support | Fixes #4080

This PR continues the work started in #4060 to add support for
cross-namespace BrokerRef for TriggerV2 in the Kafka Broker.

The core implementation enabling cross-namespace Trigger reconciliation
was authored by @Cali0707 and is reused here without functional changes.

What this PR does

This PR completes the feature by adding the missing validation and coverage:

  • Adds unit tests for TriggerV2 cross-namespace BrokerRef behavior
  • Adds broker-based E2E tests validating cross-namespace Trigger usage
  • Ensures Trigger reconciliation succeeds when Triggers and Brokers
    exist in different namespaces and the cross-namespace-event-links
    feature is enabled

Context

The functional implementation already exists; this PR focuses on making the
feature mergeable and production-ready by providing the required test
coverage.

@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 9, 2026
@knative-prow knative-prow bot requested review from Leo6Leo and aliok January 9, 2026 16:09
@knative-prow
Copy link

knative-prow bot commented Jan 9, 2026

Hi @jijo-OO7. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/control-plane labels Jan 9, 2026
@knative-prow
Copy link

knative-prow bot commented Jan 9, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jijo-OO7
Once this PR has been reviewed and has the lgtm label, please assign matzew for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Jan 9, 2026

Codecov Report

❌ Patch coverage is 38.88889% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 36.12%. Comparing base (f9ffd24) to head (efa9b47).
⚠️ Report is 19 commits behind head on main.

Files with missing lines Patch % Lines
...ol-plane/pkg/reconciler/trigger/v2/controllerv2.go 22.22% 7 Missing ⚠️
...ntrol-plane/pkg/reconciler/trigger/v2/triggerv2.go 55.55% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #4621      +/-   ##
============================================
+ Coverage     28.77%   36.12%   +7.34%     
- Complexity        0      901     +901     
============================================
  Files           294      403     +109     
  Lines         16169    20011    +3842     
  Branches          0      342     +342     
============================================
+ Hits           4653     7228    +2575     
- Misses        11063    12144    +1081     
- Partials        453      639     +186     
Flag Coverage Δ
java-unittests 67.15% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/control-plane do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Trigger BrokerRef and Cross namespace references

2 participants