Skip to content

Conversation

@knative-prow-robot
Copy link
Contributor

This is an automated cherry-pick of #894

Fix a bug where HTTPRoutes could remain after tags were removed. Stale routes are now deleted during reconciliation.

@knative-prow knative-prow bot requested review from dprotaso and skonto November 25, 2025 13:12
@knative-prow knative-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 25, 2025
@dprotaso
Copy link
Contributor

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 25, 2025
@knative-prow
Copy link

knative-prow bot commented Nov 25, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, knative-prow-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 25, 2025
@codecov
Copy link

codecov bot commented Nov 25, 2025

Codecov Report

❌ Patch coverage is 69.23077% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.38%. Comparing base (db2dbaf) to head (ddc74e3).
⚠️ Report is 1 commits behind head on release-1.19.

Files with missing lines Patch % Lines
pkg/reconciler/ingress/ingress.go 66.66% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.19     #902      +/-   ##
================================================
- Coverage         76.58%   76.38%   -0.20%     
================================================
  Files                17       17              
  Lines              1580     1266     -314     
================================================
- Hits               1210      967     -243     
+ Misses              336      263      -73     
- Partials             34       36       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dprotaso
Copy link
Contributor

/override "codecov/patch"

@knative-prow
Copy link

knative-prow bot commented Nov 25, 2025

@dprotaso: Overrode contexts on behalf of dprotaso: codecov/patch

Details

In response to this:

/override "codecov/patch"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot merged commit 64e6d63 into knative-extensions:release-1.19 Nov 25, 2025
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants