Skip to content

Conversation

@kahirokunn
Copy link
Member

I have been actively using various net-xxx projects in the Knative ecosystem, and I am particularly invested in Envoy Gateway at this time. Through this experience, I have developed a strong interest in advancing the net-gateway-api project and contributing to its progress.
I would be honored to serve as a reviewer for this project and help move it forward. I believe my experience with gateway implementations and my commitment to the Knative community would allow me to provide valuable feedback and support to contributors.
If the maintainers are open to this, I would greatly appreciate the opportunity to contribute as a reviewer.
Thank you for considering this request.

@knative-prow
Copy link

knative-prow bot commented Nov 25, 2025

There are empty aliases in OWNER_ALIASES, cleanup is advised.

@knative-prow knative-prow bot requested review from dprotaso and skonto November 25, 2025 23:53
@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 25, 2025
@codecov
Copy link

codecov bot commented Nov 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.38%. Comparing base (1836d3f) to head (c26cceb).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #903   +/-   ##
=======================================
  Coverage   76.38%   76.38%           
=======================================
  Files          17       17           
  Lines        1266     1266           
=======================================
  Hits          967      967           
  Misses        263      263           
  Partials       36       36           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dprotaso
Copy link
Contributor

/hold

Hey - I'd be great to have you as a reviewer on this repository.

Owner aliases files are synced from the knative/community repo - you'll want to update this specific file to add a reviewers team

https://github.com/knative/community/blob/main/peribolos/knative-extensions.yaml

Once you edit that file run ./hack/update-codegen.sh in that repository to update the root OWNER_ALIASES file in that repository.

Eventually that file will be synced to this repository and we just need to update the OWNERS file with the new time

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 26, 2025
@kahirokunn
Copy link
Member Author

@dprotaso
knative/community#1745
Thank you for your guidance! I tried implementing this, and would appreciate it if you could review it. Thank you in advance! 🙏

@dprotaso
Copy link
Contributor

/verify-owners

@knative-prow
Copy link

knative-prow bot commented Nov 27, 2025

There are empty aliases in OWNER_ALIASES, cleanup is advised.

@dprotaso
Copy link
Contributor

/hold cancel

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 27, 2025
@dprotaso
Copy link
Contributor

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 27, 2025
@knative-prow
Copy link

knative-prow bot commented Nov 27, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, kahirokunn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 27, 2025
@knative-prow knative-prow bot merged commit 00925ab into knative-extensions:main Nov 27, 2025
27 checks passed
@kahirokunn
Copy link
Member Author

Thank you very mush 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants