-
Notifications
You must be signed in to change notification settings - Fork 37
Add kahirokunn as a net-gateway-api-reviewers in OWNERS file #903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add kahirokunn as a net-gateway-api-reviewers in OWNERS file #903
Conversation
Signed-off-by: kahirokunn <[email protected]>
|
There are empty aliases in OWNER_ALIASES, cleanup is advised. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #903 +/- ##
=======================================
Coverage 76.38% 76.38%
=======================================
Files 17 17
Lines 1266 1266
=======================================
Hits 967 967
Misses 263 263
Partials 36 36 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/hold Hey - I'd be great to have you as a reviewer on this repository. Owner aliases files are synced from the knative/community repo - you'll want to update this specific file to add a reviewers team https://github.com/knative/community/blob/main/peribolos/knative-extensions.yaml Once you edit that file run Eventually that file will be synced to this repository and we just need to update the OWNERS file with the new time |
|
@dprotaso |
|
/verify-owners |
|
There are empty aliases in OWNER_ALIASES, cleanup is advised. |
|
/hold cancel |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso, kahirokunn The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Thank you very mush 🙏 |
I have been actively using various net-xxx projects in the Knative ecosystem, and I am particularly invested in Envoy Gateway at this time. Through this experience, I have developed a strong interest in advancing the net-gateway-api project and contributing to its progress.
I would be honored to serve as a reviewer for this project and help move it forward. I believe my experience with gateway implementations and my commitment to the Knative community would allow me to provide valuable feedback and support to contributors.
If the maintainers are open to this, I would greatly appreciate the opportunity to contribute as a reviewer.
Thank you for considering this request.