Skip to content

Conversation

@dprotaso
Copy link
Contributor

@dprotaso dprotaso commented Nov 26, 2025

@knative-prow
Copy link

knative-prow bot commented Nov 26, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot requested review from dsimansk and skonto November 26, 2025 22:08
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 26, 2025
@codecov
Copy link

codecov bot commented Nov 26, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 76.38%. Comparing base (66e594c) to head (6367f26).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
pkg/reconciler/ingress/config/store.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #907   +/-   ##
=======================================
  Coverage   76.38%   76.38%           
=======================================
  Files          17       17           
  Lines        1266     1266           
=======================================
  Hits          967      967           
  Misses        263      263           
  Partials       36       36           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@knative-prow knative-prow bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 26, 2025
@linkvt
Copy link

linkvt commented Nov 27, 2025

/lgtm

I guess this doesn't work with my permissions but I'll try:
/override codecov/patch

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 27, 2025
@knative-prow
Copy link

knative-prow bot commented Nov 27, 2025

@linkvt: linkvt unauthorized: /override is restricted to Repo administrators, and the following github teams:knative-extensions: knative-release-leads client-wg-leads eventing-wg-leads functions-wg-leads productivity-wg-leads serving-wg-leads.

Details

In response to this:

/lgtm

I guess this doesn't work with my permissions but I'll try:
/override codecov/patch

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dprotaso
Copy link
Contributor Author

/override "codecov/patch"

@knative-prow
Copy link

knative-prow bot commented Nov 27, 2025

@dprotaso: Overrode contexts on behalf of dprotaso: codecov/patch

Details

In response to this:

/override "codecov/patch"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot merged commit 5e899f6 into knative-extensions:main Nov 27, 2025
31 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants