-
Notifications
You must be signed in to change notification settings - Fork 38
drop use of deprecated knative.dev/networking/pkg #907
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drop use of deprecated knative.dev/networking/pkg #907
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #907 +/- ##
=======================================
Coverage 76.38% 76.38%
=======================================
Files 17 17
Lines 1266 1266
=======================================
Hits 967 967
Misses 263 263
Partials 36 36 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/lgtm I guess this doesn't work with my permissions but I'll try: |
|
@linkvt: linkvt unauthorized: /override is restricted to Repo administrators, and the following github teams:knative-extensions: knative-release-leads client-wg-leads eventing-wg-leads functions-wg-leads productivity-wg-leads serving-wg-leads. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override "codecov/patch" |
|
@dprotaso: Overrode contexts on behalf of dprotaso: codecov/patch DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
5e899f6
into
knative-extensions:main
Part of knative/networking#1102
/assign @kahirokunn