ingress.class config is superseded by ingress-class

[controlol]

Changes

The dot notation is superseded by the same configuration name with a dash as the replacement. When both are present the dash notation takes presence.

Look for the ingress-class key. It could also be the ingress.class key with a dot. The dash usage is more current and supersedes any key with the dot.

Source: https://knative.dev/docs/serving/config-network-adapters/

• Documentation update

/kind deprecation

Fixes #

Release Note

doc: Update config to use dash notation.

Docs

[linux-foundation-easycla]

• ❌ - login: @controlol / name: Luc Appelman . The commit (974af56) is not authorized under a signed CLA. Please click here to be authorized. For further assistance with EasyCLA, please submit a support request ticket.

[knative-prow]

Welcome @controlol! It looks like this is your first PR to knative-extensions/net-gateway-api 🎉

[knative-prow]

Hi @controlol. Thanks for your PR.

I'm waiting for a knative-extensions member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[dprotaso]

/lgtm
/approve

[knative-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: controlol, dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [dprotaso]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[dprotaso]

/ok-to-test

Are you able to sign the CLA?

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.38%. Comparing base (8142a8d) to head (974af56).

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #917   +/-   ##
=======================================
  Coverage   76.38%   76.38%           
=======================================
  Files          17       17           
  Lines        1266     1266           
=======================================
  Hits          967      967           
  Misses        263      263           
  Partials       36       36           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[dprotaso]

Hey just following up