Skip to content

Conversation

@cardil
Copy link
Contributor

@cardil cardil commented Mar 14, 2025

Changes

  • 🗑️ Remove cmd/schema usage

/kind removal

Clean up after #931
Follow up knative/hack#418

@knative-prow knative-prow bot added the kind/removal Categorizes issue or PR as related to removing dead code, or deprecated apis/features. label Mar 14, 2025
@knative-prow knative-prow bot requested review from Cali0707 and dprotaso March 14, 2025 17:30
@knative-prow knative-prow bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Mar 14, 2025
@cardil
Copy link
Contributor Author

cardil commented Mar 14, 2025

/assign @dprotaso
/cc @dsimansk
/cc @upodroid

@codecov
Copy link

codecov bot commented Mar 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 4.33%. Comparing base (adee882) to head (3d2238f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##            main    #942      +/-   ##
========================================
+ Coverage   4.23%   4.33%   +0.09%     
========================================
  Files         16      15       -1     
  Lines        307     300       -7     
========================================
  Hits          13      13              
+ Misses       294     287       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cardil
Copy link
Contributor Author

cardil commented Mar 14, 2025

/override "style / Golang / Lint"

@knative-prow
Copy link

knative-prow bot commented Mar 14, 2025

@cardil: Overrode contexts on behalf of cardil: style / Golang / Lint

Details

In response to this:

/override "style / Golang / Lint"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dprotaso
Copy link
Contributor

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Mar 14, 2025
@knative-prow
Copy link

knative-prow bot commented Mar 14, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cardil, dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 14, 2025
@dprotaso
Copy link
Contributor

linter fix is here: #941

@knative-prow knative-prow bot merged commit f255935 into knative-extensions:main Mar 14, 2025
22 of 23 checks passed
@cardil cardil deleted the chore/rm-schema branch March 14, 2025 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/removal Categorizes issue or PR as related to removing dead code, or deprecated apis/features. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants