Skip to content

Conversation

@cardil
Copy link
Contributor

@cardil cardil commented Mar 18, 2025

Changes

  • 🧹 Prepare for vendorless

/kind cleanup

Part of knative/infra#134
Ease of review for #943

@knative-prow
Copy link

knative-prow bot commented Mar 18, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@knative-prow knative-prow bot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Mar 18, 2025
@knative-prow knative-prow bot requested review from Cali0707 and upodroid March 18, 2025 10:48
@knative-prow knative-prow bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Mar 18, 2025
@cardil cardil force-pushed the cleanup/prepare-for-vendorless branch from 6c58c8a to 9867427 Compare March 18, 2025 10:49
@cardil
Copy link
Contributor Author

cardil commented Mar 18, 2025

/test all

@codecov
Copy link

codecov bot commented Mar 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 4.33%. Comparing base (763ec03) to head (7345ac1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #944   +/-   ##
=====================================
  Coverage   4.33%   4.33%           
=====================================
  Files         15      15           
  Lines        300     300           
=====================================
  Hits          13      13           
  Misses       287     287           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cardil cardil marked this pull request as ready for review March 18, 2025 10:56
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 18, 2025
@knative-prow knative-prow bot requested a review from dprotaso March 18, 2025 10:56
@cardil
Copy link
Contributor Author

cardil commented Mar 18, 2025

/assign @dprotaso
/assign @dsimansk

@knative-prow knative-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 18, 2025
@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 18, 2025
@cardil
Copy link
Contributor Author

cardil commented Mar 18, 2025

/hold

I'll file a PR vs knative.dev/hack to revert code changes if only whitespace are changed. This should fix: https://github.com/knative-extensions/sample-controller/actions/runs/13921922372/job/38956989826?pr=944

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 18, 2025
@knative-prow knative-prow bot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 18, 2025
@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 18, 2025
@cardil cardil force-pushed the cleanup/prepare-for-vendorless branch from d29e949 to a1adf72 Compare March 18, 2025 18:00
@cardil cardil force-pushed the cleanup/prepare-for-vendorless branch from a1adf72 to ced41bd Compare March 18, 2025 18:01
@dsimansk
Copy link

/approve
/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Mar 19, 2025
@knative-prow
Copy link

knative-prow bot commented Mar 19, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cardil, dsimansk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 19, 2025
@knative-prow knative-prow bot merged commit 7431471 into knative-extensions:main Mar 19, 2025
18 checks passed
@cardil cardil deleted the cleanup/prepare-for-vendorless branch March 19, 2025 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants