-
Notifications
You must be signed in to change notification settings - Fork 68
🧹 Prepare for vendorless #944
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🧹 Prepare for vendorless #944
Conversation
|
Skipping CI for Draft Pull Request. |
6c58c8a to
9867427
Compare
|
/test all |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #944 +/- ##
=====================================
Coverage 4.33% 4.33%
=====================================
Files 15 15
Lines 300 300
=====================================
Hits 13 13
Misses 287 287 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/hold I'll file a PR vs knative.dev/hack to revert code changes if only whitespace are changed. This should fix: https://github.com/knative-extensions/sample-controller/actions/runs/13921922372/job/38956989826?pr=944 |
d29e949 to
a1adf72
Compare
a1adf72 to
ced41bd
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cardil, dsimansk The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
/kind cleanup
Part of knative/infra#134
Ease of review for #943