Skip to content

Conversation

@dprotaso
Copy link
Contributor

@dprotaso dprotaso commented Jul 7, 2025

/assign @Cali0707

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 7, 2025
@knative-prow knative-prow bot requested review from Cali0707 and lionelvillard July 7, 2025 17:37
@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 7, 2025
@dprotaso
Copy link
Contributor Author

dprotaso commented Jul 7, 2025

/hold

need to update config map example

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 7, 2025
@codecov
Copy link

codecov bot commented Jul 7, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 4.33%. Comparing base (83e909e) to head (96ca429).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
cmd/webhook/main.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main    #964   +/-   ##
=====================================
  Coverage   4.33%   4.33%           
=====================================
  Files         15      15           
  Lines        300     300           
=====================================
  Hits          13      13           
  Misses       287     287           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@knative-prow knative-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 7, 2025
@dprotaso
Copy link
Contributor Author

dprotaso commented Jul 7, 2025

/hold cancel

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 7, 2025
@dprotaso dprotaso force-pushed the use-observability branch from 1e7abcb to f5042de Compare July 7, 2025 17:43
@knative-prow knative-prow bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 7, 2025
@dprotaso
Copy link
Contributor Author

dprotaso commented Jul 7, 2025

/override "codecov/patch"

@knative-prow
Copy link

knative-prow bot commented Jul 7, 2025

@dprotaso: Overrode contexts on behalf of dprotaso: codecov/patch

Details

In response to this:

/override "codecov/patch"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Member

@Cali0707 Cali0707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 7, 2025
@knative-prow
Copy link

knative-prow bot commented Jul 7, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 9768870 into knative-extensions:main Jul 7, 2025
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants