Skip to content

Updated kind version#330

Merged
knative-prow[bot] merged 3 commits intoknative-extensions:mainfrom
davidhadas:updateKind
Dec 24, 2024
Merged

Updated kind version#330
knative-prow[bot] merged 3 commits intoknative-extensions:mainfrom
davidhadas:updateKind

Conversation

@davidhadas
Copy link
Contributor

@davidhadas davidhadas commented Dec 23, 2024

Update workflow to use kind version 1.30, 1.31
Update to actions/setup-go@v4, actions/checkout@v4

@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 23, 2024
@knative-prow knative-prow bot requested review from psschwei and rhuss December 23, 2024 21:17
@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 23, 2024
@codecov
Copy link

codecov bot commented Dec 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.94%. Comparing base (f09c86c) to head (8d9212a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #330   +/-   ##
=======================================
  Coverage   73.94%   73.94%           
=======================================
  Files          46       46           
  Lines        4257     4257           
=======================================
  Hits         3148     3148           
  Misses        975      975           
  Partials      134      134           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidhadas
Copy link
Contributor Author

/lgtm
/approve

@knative-prow
Copy link

knative-prow bot commented Dec 24, 2024

@davidhadas: you cannot LGTM your own PR.

Details

In response to this:

/lgtm
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@davidhadas davidhadas self-assigned this Dec 24, 2024
@davidhadas davidhadas requested a review from rhuss December 24, 2024 10:11
@rhuss
Copy link

rhuss commented Dec 24, 2024

/approve
/lgtm

thanks for taking care :) !

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Dec 24, 2024
@knative-prow
Copy link

knative-prow bot commented Dec 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidhadas, rhuss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 40483eb into knative-extensions:main Dec 24, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants