feat: make prajjwal UX approver #1742
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow
bot
added
the
size/XS
Member
Author
Member
|
I agree, and am looking forward to becoming an approver for the UX repo! |
Signed-off-by: Calum Murray <cmurray@redhat.com>
Cali0707
force-pushed
the
prajjwalyd-ux-approver
branch
from
39f0d8a to
2fa31fc
Compare
knative-prow
bot
added
size/S
Member
|
Agree, thanks for all the effort you've put to Knative @prajjwalyd ! |
Member
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Cali0707, dprotaso The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@prajjwalyd has been an active contributor in the UX WG for over 1.5 years now, contributing many improvements and reviews. This includes acting as a mentor for the most recent LFX term. I believe @prajjwalyd is more than ready to become a UX approver, so this PR adds him as one.
Changes