Skip to content

Fixing minor doc issues #6173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
knative-prow merged 2 commits into from
Dec 5, 2024
Merged

Fixing minor doc issues #6173

knative-prow merged 2 commits into from
Dec 5, 2024

Conversation

@matzew
Copy link
Member

@matzew matzew commented Dec 5, 2024

Proposed Changes

  • fixing SNS header for sink
  • fixing bash rendering

matzew added 2 commits December 5, 2024 14:37
@matzew
💄 Correct Header
907a1d8 
Signed-off-by: Matthias Wessendorf <[email protected]>
@matzew
:neckbeard: Correct rendering of bash instructions
d9b0c96 
Signed-off-by: Matthias Wessendorf <[email protected]>
@knative-prow knative-prow bot requested review from pierDipi and skonto December 5, 2024 13:41
@knative-prow knative-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 5, 2024
@netlify
Copy link

netlify bot commented Dec 5, 2024 •
edited
Loading

✅ Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit d9b0c96
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/6751ada174ca850008a56205
😎 Deploy Preview https://deploy-preview-6173--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

dsimansk
dsimansk approved these changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@dsimansk dsimansk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Dec 5, 2024
@knative-prow
Copy link

knative-prow bot commented Dec 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 5, 2024
@knative-prow knative-prow bot merged commit 5808d0b into knative:main Dec 5, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dsimansk dsimansk dsimansk approved these changes

@pierDipi pierDipi Awaiting requested review from pierDipi

@skonto skonto Awaiting requested review from skonto

Assignees

@dsimansk dsimansk

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@matzew @dsimansk