Skip to content

Conversation

@evankanderson
Copy link
Member

Adds documentation on how to consume Knative supply chain attestations. Captures discussion from this comment, where they are unlikely otherwise to be found.

Proposed Changes

  • Adds initial security documentation, focused on supply chain security. Future security configuration documents should probably be added to the same location.

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 14, 2025
@knative-prow knative-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 14, 2025
@netlify
Copy link

netlify bot commented Jan 14, 2025

Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 824841b
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/6785e9f36ea3850008b11a07
😎 Deploy Preview https://deploy-preview-6193--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@knative-prow knative-prow bot requested review from Leo6Leo and csantanapr January 14, 2025 04:37
@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 14, 2025
@netlify
Copy link

netlify bot commented Jan 14, 2025

Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 766dc5a
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/6785eec7c9b9e90008f1a9ac
😎 Deploy Preview https://deploy-preview-6193--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 14, 2025
@dprotaso
Copy link
Member

/lgtm
/approve
/cc @davidhadas for any follow up

@knative-prow knative-prow bot requested a review from davidhadas January 14, 2025 14:36
@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 14, 2025
@knative-prow
Copy link

knative-prow bot commented Jan 14, 2025

@dprotaso: GitHub didn't allow me to request PR reviews from the following users: for, follow, up.

Note that only knative members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

/lgtm
/approve
/cc @davidhadas for any follow up

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow
Copy link

knative-prow bot commented Jan 14, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, evankanderson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [dprotaso,evankanderson]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dprotaso
Copy link
Member

/cherry-pick release-1.16

@knative-prow-robot
Copy link
Contributor

@dprotaso: once the present PR merges, I will cherry-pick it on top of release-1.16 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-1.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot merged commit 5edbf35 into knative:main Jan 14, 2025
19 checks passed
@knative-prow-robot
Copy link
Contributor

@dprotaso: new pull request created: #6195

Details

In response to this:

/cherry-pick release-1.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dprotaso
Copy link
Member

dprotaso commented Jan 14, 2025

hey @evankanderson do you recommend we remove this section https://knative.dev/docs/install/yaml-install/serving/install-serving-with-yaml/#verifying-image-signatures and link to your new page?

If not then are the steps still relevant/up-to-date?

@evankanderson
Copy link
Member Author

Good idea, I'll send a follow-up PR. I also want to revise some of the security documentation to give some more holistic guidance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants