Skip to content

Conversation

@dprotaso
Copy link
Member

  • fix broken link
  • allow script to be run from any directory

/assign @Leo6Leo

@knative-prow knative-prow bot requested review from Cali0707 and Leo6Leo February 10, 2025 21:33
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 10, 2025
@netlify
Copy link

netlify bot commented Feb 10, 2025

Deploy Preview for knative ready!

Name Link
🔨 Latest commit ef9c5c1
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/67aa70c2c5e4750008c0df4d
😎 Deploy Preview https://deploy-preview-6222--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Leo6Leo
Copy link
Member

Leo6Leo commented Feb 12, 2025

/lgtm
/approve
Tested and it works perfectly.
Thanks @dprotaso !

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 12, 2025
@knative-prow
Copy link

knative-prow bot commented Feb 12, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, Leo6Leo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit c04e50d into knative:main Feb 12, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants