Skip to content

Conversation

@matzew
Copy link
Member

@matzew matzew commented Jul 9, 2025

Adding a blog showing how elegant KubeVirt instances can be monitored with the Knative Eventing APIs

@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 9, 2025
@knative-prow knative-prow bot requested review from Cali0707 and csantanapr July 9, 2025 12:04
@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 9, 2025
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jul 9, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

@knative-prow knative-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 9, 2025
@netlify
Copy link

netlify bot commented Jul 9, 2025

Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 7bdb886
🔍 Latest deploy log https://app.netlify.com/projects/knative/deploys/686e80326c36a700087a9e33
😎 Deploy Preview https://deploy-preview-6290--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

matzew added 2 commits July 9, 2025 14:10
Signed-off-by: Matthias Wessendorf <[email protected]>
Signed-off-by: Matthias Wessendorf <[email protected]>
@matzew matzew changed the title WIP: Kubevirt/Eventing blog Kubevirt/Eventing blog Jul 9, 2025
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 9, 2025
Copy link
Member

@Cali0707 Cali0707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really cool blog @matzew @rguske !! It shows how powerful and simple this integration is.

I left a lot of small nits around wording throughout, but otherwise lgtm

matzew and others added 22 commits July 9, 2025 16:33
Signed-off-by: Matthias Wessendorf <[email protected]>
@matzew
Copy link
Member Author

matzew commented Jul 9, 2025

@Cali0707 I've updated the post! Thanks!

Copy link
Member

@Cali0707 Cali0707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

This should merge once @rguske has the CLA filled out 😄

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 9, 2025
@knative-prow
Copy link

knative-prow bot commented Jul 9, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@matzew
Copy link
Member Author

matzew commented Jul 9, 2025

the CLA is filled, but there is an issue w/ EasyCLA.

We are on a back channel for "corp. approval"

Thanks a lot for the review @Cali0707

@Cali0707
Copy link
Member

Cali0707 commented Jul 9, 2025

/check-cla

?

@knative-prow knative-prow bot merged commit e1105fa into knative:main Jul 10, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants