Conversation
✅ Deploy Preview for knative ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
this simplifies client interaction as we don't require port-fowarding anymore
52b1140 to
fe2efe6
Compare
code-samples/eventing/bookstore-sample-app/start/frontend/config/100-front-end-deployment.yaml
Outdated
Show resolved
Hide resolved
|
re-opened so we get the github rate limit fix in |
Leo6Leo
left a comment
There was a problem hiding this comment.
Haven't finished it yet. Submitting for the first round of review.
code-samples/eventing/bookstore-sample-app/start/slack-sink/application.properties
Outdated
Show resolved
Hide resolved
…plication.properties Co-authored-by: Leo Li <36619969+Leo6Leo@users.noreply.github.com>
|
bump @Leo6Leo |
|
The registry route should be updated to dynamic, and use the one that's being provided by the user input. Also the |
Want do make those changes in a follow up? |
|
|
||
| # Deploy the ML services | ||
| echo "" | ||
| echo "📦 Deploying the ML service: bad-word-filter..." |
There was a problem hiding this comment.
export DOCKER_HOST=unix://$HOME/.docker/run/docker.sock is needed for me when using local KinD cluster. Otherwise, the following error prompt:
📦 Deploying the ML service: bad-word-filter...
Building function image
Error: cannot create docker client: docker/podman API not available
Possible causes:
The docker/podman daemon is not running.
The DOCKER_HOST environment variable is not set.
There was a problem hiding this comment.
export DOCKER_HOST=unix://$HOME/.docker/run/docker.sock
That's not universal so I don't think we should tell people to do that. A requirement beforehand should be a 'working docker'
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso, Leo6Leo The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I'm hoping this supplements #6204