fix: fix indentation of codeblock in collecting metrics docs#6452
fix: fix indentation of codeblock in collecting metrics docs#6452knative-prow[bot] merged 2 commits intoknative:mainfrom
Conversation
✅ Deploy Preview for knative ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
@linkvt can you also update the serving dashboard link to be |
| data: | ||
| # metrics-protocol field specifies the protocol used when exporting metrics | ||
| # It supports either 'none' (the default), 'prometheus', 'http/protobuf' (OTLP HTTP), 'grpc' (OTLP gRPC) | ||
| metrics-protocol: prometheus |
There was a problem hiding this comment.
can we align this with name and namespace
| data: | ||
| # metrics-protocol field specifies the protocol used when exporting metrics | ||
| # It supports either 'none' (the default), 'prometheus', 'http/protobuf' (OTLP HTTP), 'grpc' (OTLP gRPC) | ||
| metrics-protocol: prometheus |
There was a problem hiding this comment.
can we align this with name and namespace
672eee0 to
3b53e37
Compare
|
Thanks for the comments @dprotaso , will be a bit more thorough next time :) , PTAL |
|
/lgtm thanks! |
|
/approved |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso, linkvt The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@linkvt: new pull request created: #6455 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Proposed Changes
/cherry-pick release-1.19
Thanks!