Skip to content

fix: fix indentation of codeblock in collecting metrics docs#6452

Merged
knative-prow[bot] merged 2 commits intoknative:mainfrom
linkvt:fix-indentation
Oct 16, 2025
Merged

fix: fix indentation of codeblock in collecting metrics docs#6452
knative-prow[bot] merged 2 commits intoknative:mainfrom
linkvt:fix-indentation

Conversation

@linkvt
Copy link
Contributor

@linkvt linkvt commented Oct 15, 2025

Proposed Changes

/cherry-pick release-1.19

Thanks!

@knative-prow knative-prow bot requested review from Leo6Leo and pierDipi October 15, 2025 13:33
@netlify
Copy link

netlify bot commented Oct 15, 2025

Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 3b53e37
🔍 Latest deploy log https://app.netlify.com/projects/knative/deploys/68f09721432713000806f439
😎 Deploy Preview https://deploy-preview-6452--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@knative-prow knative-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 15, 2025
@dprotaso
Copy link
Member

@linkvt can you also update the serving dashboard link to be json and not yaml similar to your eventing change

data:
# metrics-protocol field specifies the protocol used when exporting metrics
# It supports either 'none' (the default), 'prometheus', 'http/protobuf' (OTLP HTTP), 'grpc' (OTLP gRPC)
metrics-protocol: prometheus
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we align this with name and namespace

data:
# metrics-protocol field specifies the protocol used when exporting metrics
# It supports either 'none' (the default), 'prometheus', 'http/protobuf' (OTLP HTTP), 'grpc' (OTLP gRPC)
metrics-protocol: prometheus
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we align this with name and namespace

@linkvt
Copy link
Contributor Author

linkvt commented Oct 16, 2025

Thanks for the comments @dprotaso , will be a bit more thorough next time :) , PTAL

@dprotaso
Copy link
Member

/lgtm
/aprove

thanks!

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 16, 2025
@dprotaso
Copy link
Member

/approved

@dprotaso
Copy link
Member

/approve

@knative-prow
Copy link

knative-prow bot commented Oct 16, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, linkvt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 16, 2025
@knative-prow knative-prow bot merged commit a91b7c1 into knative:main Oct 16, 2025
19 checks passed
@knative-prow-robot
Copy link
Contributor

@linkvt: new pull request created: #6455

Details

In response to this:

Proposed Changes

/cherry-pick release-1.19

Thanks!

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants