Add EventPolicy to storage version migrator #8384
Conversation
While this is not strictly needed, this prevents issues we could run into eventually with storage version migrations. Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
knative-prow
bot
added
size/XS
| - "subscriptions.messaging.knative.dev" | ||
| - "triggers.eventing.knative.dev" | ||
| - "jobsinks.sinks.knative.dev" | ||
| - "eventpolicies.eventing.knative.dev" |
There was a problem hiding this comment.
Just to be sure, as I haven't worked with the storage-verion-migrator so far: this does not fail, when we only have one version available so far?
There was a problem hiding this comment.
there is a noop if no changes are. For most of the others we also only have on version, e.g. v1
There was a problem hiding this comment.
This reminds me of doing the same for the IntegrationSource/sink bits 😅
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8384 +/- ##
=======================================
Coverage 64.25% 64.25%
=======================================
Files 388 388
Lines 23313 23313
=======================================
Hits 14980 14980
Misses 7539 7539
Partials 794 794 ☔ View full report in Codecov by Sentry. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: matzew, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test reconciler-tests |
1 similar comment
|
/test reconciler-tests |
|
/retest |
3 participants
While this is not strictly needed right now, this prevents issues we could run into eventually with version migrations.
Fixes #
Proposed Changes
Pre-review Checklist
Release Note
Docs