-
Notifications
You must be signed in to change notification settings - Fork 618
Docs: Fix typo in development guide #8829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Ankur Verma <ankurv37@gmail.com>
|
|
|
Welcome @ankurv37! It looks like this is your first PR to knative/eventing 🎉 |
|
Hi @ankurv37. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
creydr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix @ankurv37
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ankurv37, creydr The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8829 +/- ##
=======================================
Coverage 51.11% 51.12%
=======================================
Files 409 409
Lines 21360 21360
=======================================
+ Hits 10919 10921 +2
+ Misses 9589 9588 -1
+ Partials 852 851 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Fixes #
N/A
Proposed Changes
🧹 Fixed typos in internal documentation
docs/broker/filtering.mddocs/decisions/eventing-and-messaging.mddocs/delivery/README.mdPre-review Checklist
(Documentation fix only - no code changes)
Release Note
NONE
Docs
N/A