Skip to content

Conversation

@ankurv37
Copy link
Contributor

Fixes #
N/A

Proposed Changes

🧹 Fixed typos in internal documentation

  • Fixed spelling errors in docs/broker/filtering.md
  • Fixed spelling errors in docs/decisions/eventing-and-messaging.md
  • Fixed spelling errors in docs/delivery/README.md

Pre-review Checklist

(Documentation fix only - no code changes)

  • At least 80% unit test coverage
  • E2E tests for any new behavior
  • Docs PR for any user-facing impact
  • Spec PR for any new API feature
  • Conformance test for any change to the spec

Release Note

NONE

Docs

N/A

Signed-off-by: Ankur Verma <ankurv37@gmail.com>
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Dec 28, 2025

CLA Signed
The committers listed above are authorized under a signed CLA.

  • ✅ login: ankurv37 / name: Ankur Verma (7f2fcaa)

@knative-prow
Copy link

knative-prow bot commented Dec 28, 2025

Welcome @ankurv37! It looks like this is your first PR to knative/eventing 🎉

@knative-prow
Copy link

knative-prow bot commented Dec 28, 2025

Hi @ankurv37. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 28, 2025
@knative-prow knative-prow bot requested review from creydr and matzew December 28, 2025 00:26
@creydr
Copy link
Member

creydr commented Jan 12, 2026

/ok-to-test

@knative-prow knative-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 12, 2026
Copy link
Member

@creydr creydr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @ankurv37
/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 12, 2026
@knative-prow
Copy link

knative-prow bot commented Jan 12, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ankurv37, creydr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 12, 2026
@codecov
Copy link

codecov bot commented Jan 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 51.12%. Comparing base (2d46bb0) to head (7f2fcaa).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8829   +/-   ##
=======================================
  Coverage   51.11%   51.12%           
=======================================
  Files         409      409           
  Lines       21360    21360           
=======================================
+ Hits        10919    10921    +2     
+ Misses       9589     9588    -1     
+ Partials      852      851    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@knative-prow knative-prow bot merged commit 3dac6b7 into knative:main Jan 12, 2026
32 checks passed
@ankurv37
Copy link
Contributor Author

Thanks for the fix @ankurv37 /lgtm

Thanks for the review and approve @creydr! Will start on a real one now.

@ankurv37 ankurv37 deleted the fix-typo-in-dev-docs branch January 15, 2026 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants