Skip to content

Fix IntegrationSink to use actual ServiceAccount name in auth proxy R… #8840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
knative-prow merged 1 commit into from
Jan 13, 2026
Merged

Fix IntegrationSink to use actual ServiceAccount name in auth proxy R… #8840

knative-prow merged 1 commit into from
Jan 13, 2026

Conversation

@Kunal1522
Copy link
Contributor

@Kunal1522 Kunal1522 commented Jan 12, 2026

Fixes #8838

@Kunal1522
Fix IntegrationSink to use actual ServiceAccount name in auth proxy R…
7d5881c 
…oleBindings

Previously, MakeAuthProxyRoleBindings always used "default" as the
ServiceAccount name. Now it uses makeServiceAccountName() to get the
actual SA configured in the IntegrationSink spec, falling back to
"default" if not specified.

This resolves the TODO comment that noted the need to get the real
SA of the pod.
@knative-prow knative-prow bot requested review from aliok and creydr January 12, 2026 21:07
@knative-prow
Copy link

knative-prow bot commented Jan 12, 2026

Hi @Kunal1522. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 12, 2026
@creydr
Copy link
Member

creydr commented Jan 13, 2026

/ok-to-test

@knative-prow knative-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 13, 2026
@codecov
Copy link

codecov bot commented Jan 13, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 51.13%. Comparing base (79d12a9) to head (7d5881c).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...iler/integration/sink/resources/container_image.go 0.00% 4 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8840      +/-   ##
==========================================
- Coverage   51.14%   51.13%   -0.01%     
==========================================
  Files         409      409              
  Lines       21360    21369       +9     
==========================================
+ Hits        10924    10927       +3     
- Misses       9584     9591       +7     
+ Partials      852      851       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

creydr
creydr approved these changes Jan 13, 2026
View reviewed changes
Copy link
Member

@creydr creydr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing @Kunal1522
/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 13, 2026
@knative-prow
Copy link

knative-prow bot commented Jan 13, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, Kunal1522

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 13, 2026
@knative-prow knative-prow bot merged commit cc30e85 into knative:main Jan 13, 2026
35 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@creydr creydr creydr approved these changes

@aliok aliok Awaiting requested review from aliok

Assignees

@creydr creydr

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

IntegrationSink auth-proxy RoleBinding uses hardcoded "default" ServiceAccount

2 participants

@Kunal1522 @creydr