Conversation
Detect also if pod did not exited prematurely. Signed-off-by: Matej Vašek <mvasek@redhat.com>
This commit removes depencency on sh and tar binaries by implementing the logic in our func-util binary. Signed-off-by: Matej Vašek <mvasek@redhat.com>
|
@matejvasek: The label(s) DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
knative-prow
bot
added
approved
matejvasek
requested review from
lkingland and
matzew
and removed request for
jrangelramos and
rhuss
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2672 +/- ##
==========================================
+ Coverage 64.16% 65.35% +1.18%
==========================================
Files 130 131 +1
Lines 15519 15601 +82
==========================================
+ Hits 9958 10196 +238
+ Misses 4622 4417 -205
- Partials 939 988 +49
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
/test unit-tests |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
PTAL @lkingland @gauron99 @matzew |
🎉 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lkingland, matejvasek The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
2 participants
Changes
sh/tarby implementing extraction in func-util binary. This will allow us to make func-util imageFROM scratchor base it on google's distroless image.podReady()where the function did not detect premature exit of a container.