Skip to content

Remove direct dep on golang.org/x/exp#2695

Merged
knative-prow[bot] merged 1 commit intoknative:mainfrom
matejvasek:rm-exp
Mar 10, 2025
Merged

Remove direct dep on golang.org/x/exp#2695
knative-prow[bot] merged 1 commit intoknative:mainfrom
matejvasek:rm-exp

Conversation

@matejvasek
Copy link
Contributor

No description provided.

@knative-prow knative-prow bot requested review from rhuss and vyasgun February 17, 2025 14:12
@knative-prow knative-prow bot added approved 🤖 PR has been approved by an approver from all required OWNERS files. size/XS 🤖 PR changes 0-9 lines, ignoring generated files. labels Feb 17, 2025
@matejvasek matejvasek requested review from gauron99 and lkingland and removed request for rhuss and vyasgun February 17, 2025 14:12
@codecov
Copy link

codecov bot commented Feb 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.46%. Comparing base (fa79d31) to head (93d4879).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2695      +/-   ##
==========================================
+ Coverage   62.60%   63.46%   +0.85%     
==========================================
  Files         131      131              
  Lines       15598    15598              
==========================================
+ Hits         9765     9899     +134     
+ Misses       4906     4742     -164     
- Partials      927      957      +30     
Flag Coverage Δ
e2e-test 35.88% <0.00%> (-0.05%) ⬇️
e2e-test-oncluster 34.25% <0.00%> (+1.41%) ⬆️
e2e-test-oncluster-runtime 28.61% <0.00%> (?)
e2e-test-runtime-go 26.52% <0.00%> (?)
e2e-test-runtime-node 25.92% <0.00%> (?)
e2e-test-runtime-python 25.92% <0.00%> (?)
e2e-test-runtime-quarkus 26.08% <0.00%> (?)
e2e-test-runtime-rust 25.03% <0.00%> (?)
e2e-test-runtime-springboot 25.07% <0.00%> (?)
e2e-test-runtime-typescript 26.03% <0.00%> (?)
integration-tests 49.58% <100.00%> (+1.86%) ⬆️
unit-tests 49.51% <100.00%> (?)
unit-tests-macos-latest ?
unit-tests-ubuntu-latest ?
unit-tests-windows-latest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@knative-prow-robot knative-prow-robot added the needs-rebase Cannot be merged due to conflicts with HEAD. label Feb 17, 2025
Copy link
Contributor

@gauron99 gauron99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm 🤖 PR is ready to be merged. label Feb 17, 2025
@knative-prow
Copy link

knative-prow bot commented Feb 17, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gauron99, matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [gauron99,matejvasek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Matej Vašek <mvasek@redhat.com>
@knative-prow knative-prow bot removed the lgtm 🤖 PR is ready to be merged. label Mar 10, 2025
@knative-prow-robot knative-prow-robot removed the needs-rebase Cannot be merged due to conflicts with HEAD. label Mar 10, 2025
@matejvasek matejvasek requested a review from gauron99 March 10, 2025 13:51
@gauron99
Copy link
Contributor

/lgtm

@knative-prow knative-prow bot added the lgtm 🤖 PR is ready to be merged. label Mar 10, 2025
@knative-prow knative-prow bot merged commit 2b831f9 into knative:main Mar 10, 2025
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved 🤖 PR has been approved by an approver from all required OWNERS files. lgtm 🤖 PR is ready to be merged. size/XS 🤖 PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants