Refactor data member of the InvokeMessage to be []byte#2733
Refactor data member of the InvokeMessage to be []byte#2733knative-prow[bot] merged 1 commit intoknative:mainfrom
Conversation
|
Hi @KapilSareen. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@matejvasek, could you review this to confirm if it aligns with your intent? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2733 +/- ##
==========================================
+ Coverage 64.03% 65.31% +1.27%
==========================================
Files 131 131
Lines 15591 15598 +7
==========================================
+ Hits 9984 10188 +204
+ Misses 4655 4420 -235
- Partials 952 990 +38
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This looks good. |
Signed-off-by: KapilSareen <kapilsareen584@gmail.com>
aa33af8 to
5fbdc3c
Compare
|
/ok-to-test |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: KapilSareen, matejvasek The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
Changes the datatype of
Datamember of InvokeMessage to be of type[]byteas discussed in #2715 (comment)/kind enhancement
Fixes #2732