Skip to content

Refactor data member of the InvokeMessage to be []byte#2733

Merged
knative-prow[bot] merged 1 commit intoknative:mainfrom
KapilSareen:InvokeMessage-refactor
Mar 6, 2025
Merged

Refactor data member of the InvokeMessage to be []byte#2733
knative-prow[bot] merged 1 commit intoknative:mainfrom
KapilSareen:InvokeMessage-refactor

Conversation

@KapilSareen
Copy link
Contributor

Changes

Changes the datatype of Data member of InvokeMessage to be of type []byte as discussed in #2715 (comment)

/kind enhancement

Fixes #2732

@knative-prow knative-prow bot added the kind/enhancement Feature additions or improvements to existing label Mar 4, 2025
@knative-prow knative-prow bot requested review from dsimansk and vyasgun March 4, 2025 20:55
@knative-prow
Copy link

knative-prow bot commented Mar 4, 2025

Hi @KapilSareen. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot added size/M 🤖 PR changes 30-99 lines, ignoring generated files. needs-ok-to-test 🤖 Needs an org member to approve testing labels Mar 4, 2025
@KapilSareen
Copy link
Contributor Author

@matejvasek, could you review this to confirm if it aligns with your intent?

@codecov
Copy link

codecov bot commented Mar 4, 2025

Codecov Report

Attention: Patch coverage is 35.71429% with 9 lines in your changes missing coverage. Please review.

Project coverage is 65.31%. Comparing base (d4cfaa9) to head (5fbdc3c).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
cmd/invoke.go 12.50% 7 Missing ⚠️
pkg/functions/invoke.go 66.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2733      +/-   ##
==========================================
+ Coverage   64.03%   65.31%   +1.27%     
==========================================
  Files         131      131              
  Lines       15591    15598       +7     
==========================================
+ Hits         9984    10188     +204     
+ Misses       4655     4420     -235     
- Partials      952      990      +38     
Flag Coverage Δ
e2e-test 35.88% <21.42%> (+0.03%) ⬆️
e2e-test-oncluster 34.25% <21.42%> (+1.45%) ⬆️
e2e-test-oncluster-runtime 28.61% <21.42%> (?)
e2e-test-runtime-go 26.52% <0.00%> (?)
e2e-test-runtime-node 25.90% <0.00%> (?)
e2e-test-runtime-python 25.92% <0.00%> (?)
e2e-test-runtime-quarkus 26.07% <0.00%> (?)
e2e-test-runtime-rust 25.03% <0.00%> (?)
e2e-test-runtime-springboot 25.07% <0.00%> (?)
e2e-test-runtime-typescript 26.03% <0.00%> (?)
integration-tests 51.97% <28.57%> (+2.32%) ⬆️
unit-tests 50.91% <35.71%> (?)
unit-tests-macos-latest ?
unit-tests-ubuntu-latest ?
unit-tests-windows-latest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@matejvasek
Copy link
Contributor

This looks good.

Signed-off-by: KapilSareen <kapilsareen584@gmail.com>
@KapilSareen KapilSareen force-pushed the InvokeMessage-refactor branch from aa33af8 to 5fbdc3c Compare March 5, 2025 15:30
@matejvasek
Copy link
Contributor

/ok-to-test
/approve
/lgtm

@knative-prow knative-prow bot added the ok-to-test 🤖 Non-member PR verified by an org member that is safe to test. label Mar 6, 2025
@knative-prow knative-prow bot added lgtm 🤖 PR is ready to be merged. and removed needs-ok-to-test 🤖 Needs an org member to approve testing labels Mar 6, 2025
@knative-prow
Copy link

knative-prow bot commented Mar 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: KapilSareen, matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved 🤖 PR has been approved by an approver from all required OWNERS files. label Mar 6, 2025
@knative-prow knative-prow bot merged commit 4ade4ab into knative:main Mar 6, 2025
39 checks passed
@KapilSareen KapilSareen deleted the InvokeMessage-refactor branch March 6, 2025 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved 🤖 PR has been approved by an approver from all required OWNERS files. kind/enhancement Feature additions or improvements to existing lgtm 🤖 PR is ready to be merged. ok-to-test 🤖 Non-member PR verified by an org member that is safe to test. size/M 🤖 PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Data member of the InvokeMessage structure should be []byte not string

2 participants