Skip to content

Conversation

@lkingland
Copy link
Member

  • Default builder and pusher set to embedded Host Builder/Pusher(oci)
  • Most tests clear environment
  • Environment defaults can be controlled via environment variables
  • Tests which require back-compat git binary actively check and skip when running with a cleared environment (both integration and unit).
  • Bugfixes for when run in tandem with E2E tests
  • Ignores go-created directories in the default home path (testdata)

/kind cleanup

@knative-prow knative-prow bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jun 27, 2025
@knative-prow
Copy link

knative-prow bot commented Jun 27, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lkingland

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 27, 2025
@knative-prow knative-prow bot requested review from jrangelramos and vyasgun June 27, 2025 04:08
@knative-prow knative-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 27, 2025
@codecov
Copy link

codecov bot commented Jun 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.51%. Comparing base (c865638) to head (0c6f121).
Report is 18 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2894      +/-   ##
==========================================
+ Coverage   60.83%   61.51%   +0.68%     
==========================================
  Files         129      129              
  Lines       16215    16312      +97     
==========================================
+ Hits         9865    10035     +170     
+ Misses       5429     5322     -107     
- Partials      921      955      +34     
Flag Coverage Δ
e2e-tests 42.33% <0.00%> (+1.30%) ⬆️
integration-tests 48.07% <100.00%> (+1.77%) ⬆️
unit-tests 48.14% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lkingland lkingland force-pushed the push-snkklymlxwyz branch 3 times, most recently from 696e187 to b135db6 Compare June 30, 2025 07:34
- Default builder and pusher set to embedded Host Builder/Pusher(oci)
- Most tests clear environment
- Environment defaults can be controlled via environment variables
- Tests which require back-compat `git` binary actively check and skip
  when running with a cleared environment (both integration and unit).
- Bugfixes for when run in tandem with E2E tests
- Ignores go-created directories in the default home path (testdata)
@lkingland lkingland force-pushed the push-snkklymlxwyz branch from b135db6 to 0c6f121 Compare July 1, 2025 00:53
@lkingland lkingland added the lgtm Indicates that a PR is ready to be merged. label Jul 3, 2025
@knative-prow knative-prow bot merged commit 18a119a into knative:main Jul 3, 2025
47 of 52 checks passed
@lkingland lkingland deleted the push-snkklymlxwyz branch July 3, 2025 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant