Use localtest.me instead of sslip.io #2918
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: matejvasek The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
bot
added
approved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2918 +/- ##
==========================================
+ Coverage 60.58% 61.34% +0.76%
==========================================
Files 130 130
Lines 16408 16408
==========================================
+ Hits 9940 10065 +125
+ Misses 5543 5389 -154
- Partials 925 954 +29
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
matejvasek
force-pushed
the
use-localtestme
branch
from
a4233ef to
d8ac971
Compare
Signed-off-by: Matej Vašek <[email protected]>
matejvasek
force-pushed
the
use-localtestme
branch
from
d8ac971 to
bee7f5c
Compare
matejvasek
requested review from
gauron99,
jrangelramos,
lkingland and
matzew
and removed request for
dsimansk and
nainaz
Contributor
Author
|
PTAL @jrangelramos |
Contributor
Author
|
PTAL @lkingland |
Contributor
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
localtest.medomain is shorter than127.0.0.1.sslip.io, but foremostly is hasAAAArecord.