Tests: dualstack improvements #2919
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add A and AAAA records for localtest.me depending on whether the control plane node has IPv4 and/or IPv6 address. Signed-off-by: Matej Vašek <[email protected]>
Set MetalLB address pool appropriately with respect to IPv4 and IPv6 Signed-off-by: Matej Vašek <[email protected]>
knative-prow
bot
added
the
size/M
knative-prow
bot
added
the
approved
matejvasek
requested review from
lkingland and
matzew
and removed request for
dsimansk
Contributor
Author
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2919 +/- ##
==========================================
+ Coverage 60.58% 61.34% +0.76%
==========================================
Files 130 130
Lines 16408 16408
==========================================
+ Hits 9940 10065 +125
+ Misses 5543 5389 -154
- Partials 925 954 +29
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
PTAL @lkingland |
gauron99
approved these changes
Jul 8, 2025
Contributor
gauron99
left a comment
gauron99
left a comment
There was a problem hiding this comment.
/lgtm
/hold for potential other reviews
knative-prow
bot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gauron99, matejvasek The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
Author
|
/unhold |
knative-prow
bot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.