Skip to content

Conversation

@matejvasek
Copy link
Contributor

No description provided.

Add A and AAAA records for localtest.me depending on whether
the control plane node has IPv4 and/or IPv6 address.

Signed-off-by: Matej Vašek <[email protected]>
Set MetalLB address pool appropriately with respect to IPv4 and IPv6

Signed-off-by: Matej Vašek <[email protected]>
Signed-off-by: Matej Vašek <[email protected]>
@knative-prow
Copy link

knative-prow bot commented Jul 7, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 7, 2025
@knative-prow
Copy link

knative-prow bot commented Jul 7, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot requested review from dsimansk and nainaz July 7, 2025 18:55
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 7, 2025
@codecov
Copy link

codecov bot commented Jul 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.93%. Comparing base (bb1623f) to head (037ad45).
Report is 10 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (bb1623f) and HEAD (037ad45). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (bb1623f) HEAD (037ad45)
integration-tests 1 0
e2e-tests 2 0
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2921       +/-   ##
===========================================
- Coverage   60.58%   47.93%   -12.65%     
===========================================
  Files         130      130               
  Lines       16408    16408               
===========================================
- Hits         9940     7865     -2075     
- Misses       5543     7846     +2303     
+ Partials      925      697      -228     
Flag Coverage Δ
e2e-tests ?
integration-tests ?
unit-tests 47.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Matej Vašek <[email protected]>
@matejvasek matejvasek changed the title Ipv6 experiment experiment Jul 7, 2025
Signed-off-by: Matej Vašek <[email protected]>
Signed-off-by: Matej Vašek <[email protected]>
Signed-off-by: Matej Vašek <[email protected]>
This reverts commit 4c0604a.

Signed-off-by: Matej Vašek <[email protected]>
Signed-off-by: Matej Vašek <[email protected]>
@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 11, 2025
@knative-prow-robot
Copy link

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@matejvasek matejvasek closed this Jul 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants