Skip to content

Tests: small ipv6 fixes #2923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
knative-prow merged 2 commits into from
Jul 8, 2025
Merged

Tests: small ipv6 fixes #2923

knative-prow merged 2 commits into from
Jul 8, 2025

Conversation

@matejvasek
Copy link
Contributor

@matejvasek matejvasek commented Jul 8, 2025

  • Testing gitlab instance listens on ipv6
  • Testing Contour installation prefers dualstack

@matejvasek
Tests: small ipv6 fixes
25ee4ce 
* Testing gitlab instance listens on ipv6
* Testing Contour installation prefers dualstack

Signed-off-by: Matej Vašek <[email protected]>
@knative-prow knative-prow bot requested review from jrangelramos and nainaz July 8, 2025 02:20
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 8, 2025
@matejvasek matejvasek requested review from gauron99, lkingland and matzew and removed request for nainaz July 8, 2025 02:20
@matejvasek
Copy link
Contributor Author

matejvasek commented Jul 8, 2025

PTAL @lkingland @jrangelramos

@codecov
Copy link

codecov bot commented Jul 8, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.03%. Comparing base (bb1623f) to head (7b3529b).
Report is 3 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2923      +/-   ##
==========================================
+ Coverage   60.58%   61.03%   +0.45%     
==========================================
  Files         130      130              
  Lines       16408    16490      +82     
==========================================
+ Hits         9940    10065     +125     
+ Misses       5543     5471      -72     
- Partials      925      954      +29
Flag Coverage Δ
e2e-tests 41.95% <ø> (+1.17%) ⬆️
integration-tests 55.68% <ø> (+1.47%) ⬆️
unit-tests 47.67% <ø> (-0.24%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 8, 2025
@knative-prow
Copy link

knative-prow bot commented Jul 8, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lkingland, matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [lkingland,matejvasek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@matejvasek
fixup: listen explicitly on 0.0.0.0
7b3529b 
Usually listening on '::' should also listen on 0.0.0.0.
However gitlab or nginx apparently employ IPV6_V6ONLY option so '::'
listens only on '::'.

Signed-off-by: Matej Vašek <[email protected]>
@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 8, 2025
@matejvasek
Copy link
Contributor Author

matejvasek commented Jul 8, 2025

@lkingland plz lgtm again, I had to do small fixup.

gauron99
gauron99 reviewed Jul 8, 2025
View reviewed changes
Copy link
Contributor

@gauron99 gauron99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 8, 2025
@knative-prow knative-prow bot merged commit d9389fb into knative:main Jul 8, 2025
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gauron99 gauron99 gauron99 left review comments

@lkingland lkingland lkingland approved these changes

@jrangelramos jrangelramos Awaiting requested review from jrangelramos

@matzew matzew Awaiting requested review from matzew

Assignees

@gauron99 gauron99

@lkingland lkingland

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@matejvasek @gauron99 @lkingland